github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6813] [MERGED] chore: Remove MaxLineLength suppression guidance from testing skill #43978

New Issue
Closed
opened 2026-04-23 22:39:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:39:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6813
Author: @SaintPatrck
Created: 4/20/2026
Status: ✅ Merged
Merged: 4/21/2026
Merged by: @SaintPatrck

Base: main ← Head: chore/remove-maxlinelength-suppression-guidance

📝 Commits (1)

  • 7f52073 chore: Remove MaxLineLength suppression guidance from testing skill

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 .claude/skills/testing-android-code/SKILL.md (+0 -2)

📄 Description

🎟️ Tracking

No ticket — repo tooling cleanup for the .claude/ Claude Code skill files.

📔 Objective

The testing-android-code skill contained a prominent STOP block instructing agents when to add @Suppress(\"MaxLineLength\"). In practice this primed agents to reach for the annotation reflexively even on lines well under the 100-char limit.

Detekt already runs as a pre-commit hook and flags any line that genuinely exceeds the limit, so in-skill guidance about the suppression is redundant and net-harmful. Removing the block lets detekt serve as the single source of truth.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6813 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/20/2026 **Status:** ✅ Merged **Merged:** 4/21/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `chore/remove-maxlinelength-suppression-guidance` --- ### 📝 Commits (1) - [`7f52073`](https://github.com/bitwarden/android/commit/7f5207367059e90e959b652f7fe1d83113295d85) chore: Remove MaxLineLength suppression guidance from testing skill ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.claude/skills/testing-android-code/SKILL.md` (+0 -2) </details> ### 📄 Description ## 🎟️ Tracking No ticket — repo tooling cleanup for the `.claude/` Claude Code skill files. ## 📔 Objective The `testing-android-code` skill contained a prominent STOP block instructing agents when to add `@Suppress(\"MaxLineLength\")`. In practice this primed agents to reach for the annotation reflexively even on lines well under the 100-char limit. Detekt already runs as a pre-commit hook and flags any line that genuinely exceeds the limit, so in-skill guidance about the suppression is redundant and net-harmful. Removing the block lets detekt serve as the single source of truth. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:39:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?