github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3732] [CLOSED] [TEST 2] Open email ci debuggin2 #4380

New Issue
Closed
opened 2025-11-26 23:43:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3732
Author: @dseverns-livefront
Created: 8/14/2024
Status: ❌ Closed

Base: main ← Head: open-email-ci-debuggin2

📝 Commits (10+)

  • 764c0a3 [PM-6702] Send verification email service
  • b1d0053 [PM-6702] Register finish service call
  • 5356dff [PM-6702] Add service tests
  • 81138a3 [PM-6702] Save and load region for a given email in shared preferences
  • e21487f [PM-6702] Tests for save and load region for a given email
  • 552570c [PM-6702] Update manifest to handle App Links
  • e24c6f6 [PM-6702] Convert App Link intent into a special circumstance to open Complete Registration
  • 8127d60 Merge branch 'main' into pm-6702/evf-service-calls
  • c9c35e8 Merge branch 'main' into pm-6702/evf-service-calls
  • 9b7f790 [PM-6702] Code format

📊 Changes

12 files changed (+431 additions, -3 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+12 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/util/CompleteRegistrationDataUtils.kt (+24 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/CompleteRegistrationData.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensions.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt (+9 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+33 -1)
📝 app/src/test/java/com/x8bit/bitwarden/AuthCallbackViewModelTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+58 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/auth/util/CompleteRegistrationDataUtilsTest.kt (+121 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+133 -0)

📄 Description

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3732 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/14/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `open-email-ci-debuggin2` --- ### 📝 Commits (10+) - [`764c0a3`](https://github.com/bitwarden/android/commit/764c0a3901cdf4f6f542cf6cbcfef835c16f6275) [PM-6702] Send verification email service - [`b1d0053`](https://github.com/bitwarden/android/commit/b1d0053393606e4da1513dbcf7b1f1a006ed4755) [PM-6702] Register finish service call - [`5356dff`](https://github.com/bitwarden/android/commit/5356dffe25c4b536b688e9444dfce72df96880da) [PM-6702] Add service tests - [`81138a3`](https://github.com/bitwarden/android/commit/81138a3ca8afcf76e72a30176285497fafc80210) [PM-6702] Save and load region for a given email in shared preferences - [`e21487f`](https://github.com/bitwarden/android/commit/e21487f5e003745209e8f1131f02c0e529af6f2b) [PM-6702] Tests for save and load region for a given email - [`552570c`](https://github.com/bitwarden/android/commit/552570cc2907abf1932bd7a7e9773aa0e02953d6) [PM-6702] Update manifest to handle App Links - [`e24c6f6`](https://github.com/bitwarden/android/commit/e24c6f6008941748747ddcbad573d7c2054ef957) [PM-6702] Convert App Link intent into a special circumstance to open Complete Registration - [`8127d60`](https://github.com/bitwarden/android/commit/8127d6093337e3f1daaa6469a8e1bf39ba1ea1bd) Merge branch 'main' into pm-6702/evf-service-calls - [`c9c35e8`](https://github.com/bitwarden/android/commit/c9c35e8ec4ef688578f0f2bfa8b94806c44c9e4d) Merge branch 'main' into pm-6702/evf-service-calls - [`9b7f790`](https://github.com/bitwarden/android/commit/9b7f7900fc6c0d31c88e2a47f4ce8fd0153fc443) [PM-6702] Code format ### 📊 Changes **12 files changed** (+431 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+12 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/util/CompleteRegistrationDataUtils.kt` (+24 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/CompleteRegistrationData.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensions.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt` (+9 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+33 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/AuthCallbackViewModelTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+58 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/auth/util/CompleteRegistrationDataUtilsTest.kt` (+121 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+133 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4380
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?