github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6589] [MERGED] [PM-32714] Add cookie domain-suffix resolution and fix cloud config path exclusion #43790

New Issue
Closed
opened 2026-04-23 22:27:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:27:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6589
Author: @SaintPatrck
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @SaintPatrck

Base: main ← Head: PM-32714/update-cookie-domain-handling

📝 Commits (1)

  • 1cf2644 [PM-32714] Add cookie domain-suffix resolution and fix cloud config path exclusion

📊 Changes

4 files changed (+227 additions, -116 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkCookieManagerImpl.kt (+77 -26)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkCookieManagerTest.kt (+140 -68)
📝 network/src/main/kotlin/com/bitwarden/network/interceptor/CookieInterceptor.kt (+8 -4)
📝 network/src/test/kotlin/com/bitwarden/network/interceptor/CookieInterceptorTest.kt (+2 -18)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32714

📔 Objective

Cookies stored under a parent cookieDomain (e.g., "bitwarden.com") were not found when requesting via subdomains (e.g., "api.bitwarden.com"). Additionally, cloud servers use "/config" instead of "/api/config", causing the config endpoint to hit cookie handling and read stale state.

This adds a resolveHostname helper for domain-suffix fallback, updates storeCookies to key on cookieDomain, fixes excluded path matching to cover both cloud and self-hosted config paths, and adds debug logging along the cookie management path.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6589 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-32714/update-cookie-domain-handling` --- ### 📝 Commits (1) - [`1cf2644`](https://github.com/bitwarden/android/commit/1cf264499b572a6016b3ef0757684cdea0e99491) [PM-32714] Add cookie domain-suffix resolution and fix cloud config path exclusion ### 📊 Changes **4 files changed** (+227 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkCookieManagerImpl.kt` (+77 -26) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/network/NetworkCookieManagerTest.kt` (+140 -68) 📝 `network/src/main/kotlin/com/bitwarden/network/interceptor/CookieInterceptor.kt` (+8 -4) 📝 `network/src/test/kotlin/com/bitwarden/network/interceptor/CookieInterceptorTest.kt` (+2 -18) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-32714 ## 📔 Objective Cookies stored under a parent cookieDomain (e.g., "bitwarden.com") were not found when requesting via subdomains (e.g., "api.bitwarden.com"). Additionally, cloud servers use "/config" instead of "/api/config", causing the config endpoint to hit cookie handling and read stale state. This adds a `resolveHostname` helper for domain-suffix fallback, updates `storeCookies` to key on `cookieDomain`, fixes excluded path matching to cover both cloud and self-hosted config paths, and adds debug logging along the cookie management path. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:27:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?