github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 12:58:36 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6580] [MERGED] PM-29870: Add explicit traversal order for scaffold #43782

New Issue
Closed
opened 2026-04-23 22:27:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:27:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6580
Author: @david-livefront
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @david-livefront

Base: main ← Head: PM-29870-scaffold-traversal-order

📝 Commits (1)

  • 8b7786b PM-29870: Add explicit traversal order for scaffold

📊 Changes

1 file changed (+78 additions, -18 deletions)

View changed files

📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/scaffold/BitwardenScaffold.kt (+78 -18)

📄 Description

🎟️ Tracking

PM-29870

📔 Objective

This PR updates the traversal order inside of the BitwardenScaffold to ensure that it always navigate correctly when TalkBack is on. Previously it would navigate in awkward ways because of the custom layouts inside.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6580 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-29870-scaffold-traversal-order` --- ### 📝 Commits (1) - [`8b7786b`](https://github.com/bitwarden/android/commit/8b7786b2fd692e5f2e103e18b3ea657fec9552a4) PM-29870: Add explicit traversal order for scaffold ### 📊 Changes **1 file changed** (+78 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/scaffold/BitwardenScaffold.kt` (+78 -18) </details> ### 📄 Description ## 🎟️ Tracking [PM-29870](https://bitwarden.atlassian.net/browse/PM-29870) ## 📔 Objective This PR updates the traversal order inside of the `BitwardenScaffold` to ensure that it always navigate correctly when TalkBack is on. Previously it would navigate in awkward ways because of the custom layouts inside. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/ec07ce98-fb2c-478c-9cd2-3c74c63aa0e7" width="350" /> [PM-29870]: https://bitwarden.atlassian.net/browse/PM-29870?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:27:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43782
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?