github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3721] [MERGED] PM-10619 screen to generate master password #4372

New Issue
Closed
opened 2025-11-26 23:43:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3721
Author: @dseverns-livefront
Created: 8/13/2024
Status: ✅ Merged
Merged: 8/13/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10619/gen-mp-screen

📝 Commits (6)

📊 Changes

9 files changed (+796 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+8 -3)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorNavigation.kt (+32 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreen.kt (+224 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorViewModel.kt (+207 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationMasterPasswordExtensions.kt (+17 -0)
📝 app/src/main/res/values/strings.xml (+4 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreenTest.kt (+107 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorViewModelTest.kt (+138 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationMasterPasswordExtensionsTest.kt (+59 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10619

📔 Objective

Screen for onboarding flow allowing users to generate a passphrase to use as their master password.

📸 Screenshots

Forced the navigation to screen on opening the LogInScreen

https://github.com/user-attachments/assets/5fcb0348-17d1-48dd-8402-b93008897cd8

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3721 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/13/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10619/gen-mp-screen` --- ### 📝 Commits (6) - [`a2a82af`](https://github.com/bitwarden/android/commit/a2a82af42e2300220d2ffc84c31e3af99fb24934) PM-10619 screen to generate master password - [`1401c7a`](https://github.com/bitwarden/android/commit/1401c7ac8fa2e9eaec5621d424862d61abb6b307) feedback - [`5a89b91`](https://github.com/bitwarden/android/commit/5a89b91e2217c90dfb36e316acdb33ef4aa39eff) move to top appbar - [`fb08857`](https://github.com/bitwarden/android/commit/fb088577f6cd1aca4c5695a09d8b831e916f4559) feedbacK - [`704949d`](https://github.com/bitwarden/android/commit/704949dd9823080802b048a356d5a8c789e019c6) diff - [`9f2026d`](https://github.com/bitwarden/android/commit/9f2026d0f7c612429152301177bdf404d3fd859c) detekt ### 📊 Changes **9 files changed** (+796 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+8 -3) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorNavigation.kt` (+32 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreen.kt` (+224 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorViewModel.kt` (+207 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationMasterPasswordExtensions.kt` (+17 -0) 📝 `app/src/main/res/values/strings.xml` (+4 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreenTest.kt` (+107 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorViewModelTest.kt` (+138 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/util/PolicyInformationMasterPasswordExtensionsTest.kt` (+59 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10619 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Screen for onboarding flow allowing users to generate a passphrase to use as their master password. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots **Forced the navigation to screen on opening the `LogInScreen`** https://github.com/user-attachments/assets/5fcb0348-17d1-48dd-8402-b93008897cd8 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?