github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 22:08:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6507] [MERGED] [PM-31993] Add cookie vendor deep link intent filter #43719

New Issue
Closed
opened 2026-04-23 22:23:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:23:34 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6507
Author: @SaintPatrck
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @SaintPatrck

Base: main ← Head: cookie-vending/p4-t6_intent-filter

📝 Commits (1)

  • cb29510 [PM-31993] Add cookie vendor deep link intent filter

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+10 -0)

📄 Description

🎟️ Tracking

PM-31993

📔 Objective

Declare deep link intent filter for sso cookie vending callback.

Manifest Change:

  • Added intent filter to AuthCallbackActivity
  • Handles bitwarden://sso_cookie_vendor callbacks
  • Follows existing SSO/Duo/WebAuthn callback pattern

Intent Filter:

  • Scheme: "bitwarden"
  • Host: "sso_cookie_vendor"
  • Actions: VIEW
  • Categories: DEFAULT, BROWSABLE

Enables app to receive cookie callbacks from browser-based SSO flows.

Verification: adb shell am start -a android.intent.action.VIEW -d "bitwarden://sso_cookie_vendor?AWSELB=test"

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6507 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `cookie-vending/p4-t6_intent-filter` --- ### 📝 Commits (1) - [`cb29510`](https://github.com/bitwarden/android/commit/cb29510a3e545a27f5243d388e6166f35bc58eb5) [PM-31993] Add cookie vendor deep link intent filter ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+10 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-31993 ## 📔 Objective Declare deep link intent filter for sso cookie vending callback. Manifest Change: - Added intent filter to AuthCallbackActivity - Handles bitwarden://sso_cookie_vendor callbacks - Follows existing SSO/Duo/WebAuthn callback pattern Intent Filter: - Scheme: "bitwarden" - Host: "sso_cookie_vendor" - Actions: VIEW - Categories: DEFAULT, BROWSABLE Enables app to receive cookie callbacks from browser-based SSO flows. Verification: `adb shell am start -a android.intent.action.VIEW -d "bitwarden://sso_cookie_vendor?AWSELB=test"` ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:23:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43719