github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6502] [MERGED] [PM-31980] Fix passkeys on some browsers by fixing JSON parsing #43716

New Issue
Closed
opened 2026-04-23 22:23:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:23:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6502
Author: @Darkness4
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @SaintPatrck

Base: main ← Head: chore/fix-passkey-community

📝 Commits (1)

  • ee69a69 Remove extra comma and fix JSON parsing

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/src/main/assets/fido2_privileged_community.json (+1 -1)

📄 Description

🎟️ Tracking

Closes #6463
Closes PM-31597

📔 Objective

Fix JSON parsing by removing comma, which caused passkeys to stop working on some browsers.

Regression introduced with #6299 (PM-30260).

Sorry if I shortcut some processes, but the fix is pretty short.

Tested on Fennec. If you close my PR to develop a long-term solution (adding some tests), I don't mind.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6502 **Author:** [@Darkness4](https://github.com/Darkness4) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `chore/fix-passkey-community` --- ### 📝 Commits (1) - [`ee69a69`](https://github.com/bitwarden/android/commit/ee69a69e4a2662afd0f39afeb30914c3bbf5f959) Remove extra comma and fix JSON parsing ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/assets/fido2_privileged_community.json` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking Closes #6463 Closes PM-31597 ## 📔 Objective Fix JSON parsing by removing comma, which caused passkeys to stop working on some browsers. Regression introduced with #6299 (PM-30260). Sorry if I shortcut some processes, but the fix is pretty short. Tested on Fennec. If you close my PR to develop a long-term solution (adding some tests), I don't mind. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:23:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43716
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?