github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3697] [MERGED] [PM-10618] MP guidance screen with info and clickable card to navigate … #4353

New Issue
Closed
opened 2025-11-26 23:43:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3697
Author: @dseverns-livefront
Created: 8/8/2024
Status: ✅ Merged
Merged: 8/8/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10618/mp-guiadance-screen

📝 Commits (10+)

  • 80ecd98 PM-10618 MP guidance screen with info and clickable card to navigate to future pw screen
  • cca900c feedback
  • 330b095 revert 300
  • f87b907 : ' (
  • bf1d352 new arrangement
  • bd24630 modifier before Modifier except after sometimes
  • 0d37390 explicit sizes 4 icons
  • b8103bd dkdjfdklfjsdflkdj
  • 94bb454 bye bye magic number
  • b0b733d first things first, RIP uncle fill, for real

📊 Changes

7 files changed (+457 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+7 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceNavigation.kt (+32 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+251 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceViewModel.kt (+64 -0)
📝 app/src/main/res/values/strings.xml (+8 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreenTest.kt (+67 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceViewModelTest.kt (+28 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10618

📔 Objective

Draw the MP guidance screen according to design spec and add functionality for "closing" and fwd navigation.

📸 Screenshots

figma preview
Cell image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3697 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/8/2024 **Status:** ✅ Merged **Merged:** 8/8/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10618/mp-guiadance-screen` --- ### 📝 Commits (10+) - [`80ecd98`](https://github.com/bitwarden/android/commit/80ecd98bf45c72530af681526f6a3dba6c16ab42) PM-10618 MP guidance screen with info and clickable card to navigate to future pw screen - [`cca900c`](https://github.com/bitwarden/android/commit/cca900c9cd8de743df6b48c842b2c87944ee46e8) feedback - [`330b095`](https://github.com/bitwarden/android/commit/330b095633872e27576df8a9388f4b570f1c6641) revert 300 - [`f87b907`](https://github.com/bitwarden/android/commit/f87b907b630ab56188ca566e9936082d4ba6e2d5) : ' ( - [`bf1d352`](https://github.com/bitwarden/android/commit/bf1d352165369f4a1b5c5f18523a76ca9f972a46) new arrangement - [`bd24630`](https://github.com/bitwarden/android/commit/bd246309eb8b8a61aa6ac9e821c94da1c021afe6) modifier before Modifier except after sometimes - [`0d37390`](https://github.com/bitwarden/android/commit/0d37390a84513adabb27619f919accd7edc57415) explicit sizes 4 icons - [`b8103bd`](https://github.com/bitwarden/android/commit/b8103bd26fe2a9ef21634293ae93ac645d661178) dkdjfdklfjsdflkdj - [`94bb454`](https://github.com/bitwarden/android/commit/94bb4548b77e534733692ef57a7d6e4d959cc18c) bye bye magic number - [`b0b733d`](https://github.com/bitwarden/android/commit/b0b733d3ad44bc7c24bdcf957f900630669e05da) first things first, RIP uncle fill, for real ### 📊 Changes **7 files changed** (+457 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+7 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceNavigation.kt` (+32 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+251 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceViewModel.kt` (+64 -0) 📝 `app/src/main/res/values/strings.xml` (+8 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreenTest.kt` (+67 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceViewModelTest.kt` (+28 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10618 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Draw the MP guidance screen according to design spec and add functionality for "closing" and fwd navigation. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots | figma | preview | |--------|--------| | [Cell](https://www.figma.com/design/MSaj0DpjVEqCONBcV4WnKD/Bitwarden-Android-Mobile-App-Reskin---V2-(onboarding)?node-id=67412-73438&m=dev) | ![image](https://github.com/user-attachments/assets/05e3d327-33e2-4b3e-a3b6-70afa1a9457a) | <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4353
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?