github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3695] [MERGED] [PM-10065] Use appropriate back behavior depending on how you are take to auth approval screen #4351

New Issue
Closed
opened 2025-11-26 23:43:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3695
Author: @dseverns-livefront
Created: 8/7/2024
Status: ✅ Merged
Merged: 8/8/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10065/handle-special-circumstance-to-dismiss-approval-screen

📝 Commits (3)

  • 3b938cf PM-10065 consider the appropriate event to fire if we are entering this screen via a special circumstance
  • 470e0d7 feedback
  • 33375a2 feedback

📊 Changes

2 files changed (+86 additions, -8 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModel.kt (+10 -8)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModelTest.kt (+76 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10065

📔 Objective

Resolve bug where the LoginApproval screen would not dismiss if entered via the notification.

Testing locally

To test locally you can apply this patch to force the notification:
throwaway_code_to_trigger_auth_notification.patch

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3695 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/7/2024 **Status:** ✅ Merged **Merged:** 8/8/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10065/handle-special-circumstance-to-dismiss-approval-screen` --- ### 📝 Commits (3) - [`3b938cf`](https://github.com/bitwarden/android/commit/3b938cf599ee94ee096a4cd1cb870226ff5acc5c) PM-10065 consider the appropriate event to fire if we are entering this screen via a special circumstance - [`470e0d7`](https://github.com/bitwarden/android/commit/470e0d7b1db62ecd40df775c2bdf7e9dd56f5aa4) feedback - [`33375a2`](https://github.com/bitwarden/android/commit/33375a20dbd613b9d1757f8947e8e031f84197dd) feedback ### 📊 Changes **2 files changed** (+86 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModel.kt` (+10 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModelTest.kt` (+76 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10065 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Resolve bug where the LoginApproval screen would not dismiss if entered via the notification. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## Testing locally To test locally you can apply this patch to force the notification: [throwaway_code_to_trigger_auth_notification.patch](https://github.com/user-attachments/files/16532282/throwaway_code_to_trigger_auth_notification.patch) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?