github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6225] [MERGED] [PM-29097] Fix privacy statement alignment in landscape mode #43504

New Issue
Closed
opened 2026-04-23 22:08:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:08:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6225
Author: @SaintPatrck
Created: 12/3/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-29097/center-privacy-statement-and-terms

📝 Commits (1)

  • 459575e [BWA-207] Fix privacy statement alignment in landscape mode

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+1 -0)

📄 Description

🎟️ Tracking

PM-29097
#6214

📔 Objective

Fixes #6214 where the privacy statement and terms of service text on the Create Account screen was not properly centered when displayed in landscape orientation.

The issue occurred because the Text component containing the legal disclaimer only occupied its natural content width, causing textAlign = TextAlign.Center to center text within a narrow bounds rather than across the full screen width. This was particularly noticeable in landscape mode on devices like the Samsung S24 Ultra.

The fix adds fillMaxWidth() modifier to the Text component, ensuring it expands to occupy the full available width and properly centers the content across all orientations.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6225 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 12/3/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-29097/center-privacy-statement-and-terms` --- ### 📝 Commits (1) - [`459575e`](https://github.com/bitwarden/android/commit/459575ec4f7be92393e31ba492558d9b12ea2007) [BWA-207] Fix privacy statement alignment in landscape mode ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-29097 #6214 ## 📔 Objective Fixes #6214 where the privacy statement and terms of service text on the Create Account screen was not properly centered when displayed in landscape orientation. The issue occurred because the `Text` component containing the legal disclaimer only occupied its natural content width, causing `textAlign = TextAlign.Center` to center text within a narrow bounds rather than across the full screen width. This was particularly noticeable in landscape mode on devices like the Samsung S24 Ultra. The fix adds `fillMaxWidth()` modifier to the `Text` component, ensuring it expands to occupy the full available width and properly centers the content across all orientations. ## 📸 Screenshots | Before | After | |--------|--------| | <img width="751" src="https://github.com/user-attachments/assets/578bd4a2-29e9-4d0c-9511-1901868c30b8" /> | <img width="790" src="https://github.com/user-attachments/assets/14332a58-7b00-490c-a5ab-5857e8e2ae4c" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:08:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43504
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?