github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3694] [MERGED] [PM-10670] Prompt for PIN creation during passkey user verification #4350

New Issue
Closed
opened 2025-11-26 23:43:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3694
Author: @SaintPatrck
Created: 8/7/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-10670/prompt-device-pin-setup

📝 Commits (1)

  • 6ed7477 [PM-10670] Prompt for PIN creation during passkey user verification

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+1 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+2 -0)

📄 Description

🎟️ Tracking

PM-10670

📔 Objective

Prompt for PIN creation when performing FIDO 2 user verification if the user is using TDE, does not have a master password, and has not previously setup a PIN.

How does this change fix the issue?
During FIDO 2 user verification flows, we only need to know if a PIN has been setup. We don't technically care what the vault unlock method is because we're performing user verification, not unlocking the vault.

📸 Screenshots

passkey-uv-pin-setup.webm

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3694 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 8/7/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-10670/prompt-device-pin-setup` --- ### 📝 Commits (1) - [`6ed7477`](https://github.com/bitwarden/android/commit/6ed7477eef4aa87d6fa690132dd256b0293138b4) [PM-10670] Prompt for PIN creation during passkey user verification ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+1 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-10670 ## 📔 Objective Prompt for PIN creation when performing FIDO 2 user verification if the user is using TDE, does not have a master password, and has not previously setup a PIN. How does this change fix the issue? During FIDO 2 user verification flows, we only need to know if a PIN has been setup. We don't technically care what the vault unlock method is because we're performing user verification, not unlocking the vault. ## 📸 Screenshots [passkey-uv-pin-setup.webm](https://github.com/user-attachments/assets/1f0f4f99-9a38-4777-b223-5a2211c9df67) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?