github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3683] [MERGED] [PM-10071] Sort search items with same logic as displayed items #4339

New Issue
Closed
opened 2025-11-26 23:43:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3683
Author: @dseverns-livefront
Created: 8/6/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10071/sort-searches

📝 Commits (4)

📊 Changes

1 file changed (+15 additions, -2 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+15 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10071

📔 Objective

Show search results in the same sort order as the items appear when displayed.

📸 Screenshots

before after
https://github.com/user-attachments/assets/3494ddbe-34cd-4799-a71c-f93226078f25 https://github.com/user-attachments/assets/6157db12-9223-4c4b-9678-efcf1940708e

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3683 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/6/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10071/sort-searches` --- ### 📝 Commits (4) - [`707d162`](https://github.com/bitwarden/android/commit/707d1628376cf66208578143f05acafc897649b0) PM-10071 sort display items in the search content view to match rest of item sorting - [`51a1f25`](https://github.com/bitwarden/android/commit/51a1f25d6622c1af27c51d2837c46b8a09142420) pr feedback - [`3afd925`](https://github.com/bitwarden/android/commit/3afd925de028c08c51008ea000df0c892ce91ef6) fmt - [`e4aab75`](https://github.com/bitwarden/android/commit/e4aab75634f9cd90ad39f7dd125459754b656e6b) mvmt ### 📊 Changes **1 file changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+15 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10071 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Show search results in the same sort order as the items appear when displayed. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots | before | after | |--------|--------| | https://github.com/user-attachments/assets/3494ddbe-34cd-4799-a71c-f93226078f25 | https://github.com/user-attachments/assets/6157db12-9223-4c4b-9678-efcf1940708e | <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?