github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3671] [CLOSED] [PM-10575] Implement - New bank card #4330

New Issue
Closed
opened 2025-11-26 23:43:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3671
Author: @yugeshjain
Created: 8/4/2024
Status: ❌ Closed

Base: main ← Head: card-ui

📝 Commits (1)

  • 52666c1 implement - New Bank Card

📊 Changes

8 files changed (+539 additions, -0 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/components/BankCardContent.kt (+414 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+15 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt (+12 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/util/Constants.kt (+8 -0)
➕ app/src/main/res/drawable/copy_icon.xml (+5 -0)
➕ app/src/main/res/drawable/icon_eye.xml (+23 -0)
➕ app/src/main/res/drawable/icon_eye_off.xml (+30 -0)
➕ app/src/main/res/drawable/purple_card_bg.xml (+32 -0)

📄 Description

🎟️ Tracking

This change is based on my personal recommendation, leveraging my expertise and experience in Android development to enhance the visual representation of the bank card.

📔 Objective

This pull request introduces a subjective, yet improved visual representation of a bank card

📸 Screenshots

Theme Light Dark
Videos
Normal Font Screenshots
Small Font Screenshots
Large Font Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3671 **Author:** [@yugeshjain](https://github.com/yugeshjain) **Created:** 8/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `card-ui` --- ### 📝 Commits (1) - [`52666c1`](https://github.com/bitwarden/android/commit/52666c198e02a330cc9a106ddd2d3173ee8253dc) implement - New Bank Card ### 📊 Changes **8 files changed** (+539 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/components/BankCardContent.kt` (+414 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+15 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt` (+12 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/util/Constants.kt` (+8 -0) ➕ `app/src/main/res/drawable/copy_icon.xml` (+5 -0) ➕ `app/src/main/res/drawable/icon_eye.xml` (+23 -0) ➕ `app/src/main/res/drawable/icon_eye_off.xml` (+30 -0) ➕ `app/src/main/res/drawable/purple_card_bg.xml` (+32 -0) </details> ### 📄 Description ## 🎟️ Tracking This change is based on my personal recommendation, leveraging my expertise and experience in Android development to enhance the visual representation of the bank card. ## 📔 Objective This pull request introduces a subjective, yet improved visual representation of a bank card ## 📸 Screenshots | Theme | Light | Dark | |--------|--------|--------| | Videos | <video src="https://github.com/user-attachments/assets/4a2150cc-dc36-4798-8cf0-fbaf5e7f8be5"/> | <video src="https://github.com/user-attachments/assets/d7c91fa0-5533-4e2d-84be-9e277511a7a8"/> | | Normal Font Screenshots | <img src="https://github.com/user-attachments/assets/31405c7a-d196-4ad1-a78e-aca8a838ae0f"/> | <img src="https://github.com/user-attachments/assets/9a532249-e3c0-4900-9895-009e61b5aa90"/> | | Small Font Screenshots | <img src="https://github.com/user-attachments/assets/64a359cb-58db-49ad-8683-e5d3d50048d4"/> | <img src="https://github.com/user-attachments/assets/c5018acd-d239-4d64-9d71-8d7a0e0552ee"/> | | Large Font Screenshots | <img src="https://github.com/user-attachments/assets/85c03e38-ff19-4bc9-954d-bb0b0e1e78c4"/> | <img src="https://github.com/user-attachments/assets/eb8fd572-fa3e-4700-84c5-9f7ff3daaf09"/> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?