github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3668] [MERGED] PM-10559: Add logic to re-evaluate invalid password fields for Autofill #4328

New Issue
Closed
opened 2025-11-26 23:43:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:43:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3668
Author: @david-livefront
Created: 8/2/2024
Status: ✅ Merged
Merged: 8/2/2024
Merged by: @david-livefront

Base: main ← Head: PM-10559-autofill-fix

📝 Commits (1)

  • 30cc7ea PM-10559: Add logic to re-evaluate invalid password fields for Autofill

📊 Changes

10 files changed (+181 additions, -33 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/model/AutofillView.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/parser/AutofillParserImpl.kt (+44 -14)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/ViewNodeExtensions.kt (+8 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/builder/FillResponseBuilderTest.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/builder/SaveInfoBuilderTest.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/parser/AutofillParserTests.kt (+72 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/util/AutofillPartitionExtensionsTest.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/util/AutofillViewExtensionsTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/util/FilledDataExtensionsTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/util/ViewNodeExtensionsTest.kt (+47 -17)

📄 Description

🎟️ Tracking

PM-10559

📔 Objective

This PR addresses a bug found while testing the Capital One banking app where the password field is marked invalid but needs to be re-checked if no other password fields are found.

This logic is pulled directly out of the Maui app to ensure identical functionality. The Maui code can be found here.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3668 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 8/2/2024 **Status:** ✅ Merged **Merged:** 8/2/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-10559-autofill-fix` --- ### 📝 Commits (1) - [`30cc7ea`](https://github.com/bitwarden/android/commit/30cc7ea78af71750b6e666fcfd078b52142b320d) PM-10559: Add logic to re-evaluate invalid password fields for Autofill ### 📊 Changes **10 files changed** (+181 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/model/AutofillView.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/parser/AutofillParserImpl.kt` (+44 -14) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/ViewNodeExtensions.kt` (+8 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/builder/FillResponseBuilderTest.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/builder/SaveInfoBuilderTest.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/parser/AutofillParserTests.kt` (+72 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/util/AutofillPartitionExtensionsTest.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/util/AutofillViewExtensionsTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/util/FilledDataExtensionsTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/util/ViewNodeExtensionsTest.kt` (+47 -17) </details> ### 📄 Description ## 🎟️ Tracking [PM-10559](https://bitwarden.atlassian.net/browse/PM-10559) ## 📔 Objective This PR addresses a bug found while testing the Capital One banking app where the password field is marked invalid but needs to be re-checked if no other password fields are found. This logic is pulled directly out of the Maui app to ensure identical functionality. The Maui code can be found [here](https://github.com/bitwarden/mobile/blob/main/src/App/Platforms/Android/Autofill/FieldCollection.cs#L65). ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-10559]: https://bitwarden.atlassian.net/browse/PM-10559?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:43:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?