github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5945] [MERGED] Commonize minor UI utility functions #43265

New Issue
Closed
opened 2026-04-23 21:53:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 21:53:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5945
Author: @david-livefront
Created: 9/26/2025
Status: ✅ Merged
Merged: 9/26/2025
Merged by: @david-livefront

Base: main ← Head: common-ui-utils

📝 Commits (1)

  • 053b501 Commonize minor UI utility functions

📊 Changes

12 files changed (+30 additions, -141 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt (+1 -1)
➖ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/util/AppThemeExtensions.kt (+0 -16)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/ChooseSaveLocationDialog.kt (+2 -2)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/dialog/BitwardenSelectionDialog.kt (+1 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/field/BitwardenPasswordField.kt (+6 -2)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/util/DialogExtensions.kt (+0 -35)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/util/NonLetterColorVisualTransformation.kt (+0 -62)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt (+1 -0)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/util/AppThemeExtensions.kt (+0 -16)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/NonLetterColorVisualTransformation.kt (+5 -5)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/util/AppThemeExtensions.kt (+13 -0)
📝 ui/src/testFixtures/kotlin/com/bitwarden/ui/platform/util/AppThemeExtensionsTest.kt (+1 -1)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR commonizes a handful of UI utilities for both Password Manager and Authenticator.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5945 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `common-ui-utils` --- ### 📝 Commits (1) - [`053b501`](https://github.com/bitwarden/android/commit/053b501e35a97e0d842db95f0530996285367608) Commonize minor UI utility functions ### 📊 Changes **12 files changed** (+30 additions, -141 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt` (+1 -1) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/util/AppThemeExtensions.kt` (+0 -16) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/ChooseSaveLocationDialog.kt` (+2 -2) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/dialog/BitwardenSelectionDialog.kt` (+1 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/field/BitwardenPasswordField.kt` (+6 -2) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/util/DialogExtensions.kt` (+0 -35) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/util/NonLetterColorVisualTransformation.kt` (+0 -62) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt` (+1 -0) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/util/AppThemeExtensions.kt` (+0 -16) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/util/NonLetterColorVisualTransformation.kt` (+5 -5) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/util/AppThemeExtensions.kt` (+13 -0) 📝 `ui/src/testFixtures/kotlin/com/bitwarden/ui/platform/util/AppThemeExtensionsTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR commonizes a handful of UI utilities for both Password Manager and Authenticator. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 21:53:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?