github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5865] [MERGED] [PM-25640] Dialog flickers when switching accounts #43194

New Issue
Closed
opened 2026-04-23 21:49:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 21:49:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5865
Author: @andrebispo5
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @andrebispo5

Base: main ← Head: pm-25640/error-decryption-flicker

📝 Commits (2)

  • 8e85969 [PM-25640] Increase vault data delay to avoid view recreation flicker
  • 59105a9 [PM-25640] If the dialog was not dismissed assign it again.

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+3 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25640

📔 Objective

Fix bug where decryption error dialog will flicker and disappear when user is changing between accounts. This is due to the activity being recreated and so we have to reassign the same dialog again to avoid this event.

📸 Screenshots

OLD

https://github.com/user-attachments/assets/2de59dae-3e28-4844-b049-a7e68d742e69

NEW

https://github.com/user-attachments/assets/706fe4f9-0fca-4c2b-bd5c-5f271405810b

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5865 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-25640/error-decryption-flicker` --- ### 📝 Commits (2) - [`8e85969`](https://github.com/bitwarden/android/commit/8e8596938046cd108474e65b43dd7db35dabca13) [PM-25640] Increase vault data delay to avoid view recreation flicker - [`59105a9`](https://github.com/bitwarden/android/commit/59105a954c72de558f95ce2d8cfa45a3a0e92044) [PM-25640] If the dialog was not dismissed assign it again. ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+3 -1) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-25640 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Fix bug where decryption error dialog will flicker and disappear when user is changing between accounts. This is due to the activity being recreated and so we have to reassign the same dialog again to avoid this event. ## 📸 Screenshots ### OLD https://github.com/user-attachments/assets/2de59dae-3e28-4844-b049-a7e68d742e69 ### NEW https://github.com/user-attachments/assets/706fe4f9-0fca-4c2b-bd5c-5f271405810b ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 21:49:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?