github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3657] [MERGED] PM-10242 PM-10243 PM-10244 PM-10245 PM-10246: Welcome carousel #4319

New Issue
Closed
opened 2025-11-26 23:42:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:42:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3657
Author: @shannon-livefront
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @shannon-livefront

Base: main ← Head: PM-10242-welcome-carousel

📝 Commits (8)

  • f20e64e PM-10242 PM-10243 PM-10244 PM-10245 PM-10246: Welcome carousel
  • 6d8a4a4 Feedback updates and added feature flag
  • a246689 Update
  • 95b7cdf Don't force refresh
  • b73bcbf Use synchronous feature flag
  • f518bea Fix test
  • 61c5bdb Rename title string resources
  • 27f33bf I promise I'm literate...

📊 Changes

19 files changed (+1026 additions, -8 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+9 -1)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt (+32 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt (+272 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModel.kt (+161 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+15 -3)
➕ app/src/main/res/drawable/welcome_1.xml (+73 -0)
➕ app/src/main/res/drawable/welcome_2.xml (+58 -0)
➕ app/src/main/res/drawable/welcome_3.xml (+46 -0)
➕ app/src/main/res/drawable/welcome_4.xml (+56 -0)
📝 app/src/main/res/values/strings.xml (+8 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+20 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt (+124 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModelTest.kt (+95 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt (+9 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+29 -4)

📄 Description

🎟️ Tracking

PM-10242
PM-10243
PM-10244
PM-10245
PM-10246

📔 Objective

Add a new welcome carousel before the landing page for users who are opening the app for the first time (ie, who have never logged in or created an account on the device before)

NOTE: For now, the old landing page and create account views are shown, just to make sure the buttons work. It looks a little strange, but the auth flow will be updated more in later tickets.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3657 **Author:** [@shannon-livefront](https://github.com/shannon-livefront) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@shannon-livefront](https://github.com/shannon-livefront) **Base:** `main` ← **Head:** `PM-10242-welcome-carousel` --- ### 📝 Commits (8) - [`f20e64e`](https://github.com/bitwarden/android/commit/f20e64e256541b129024875abeb462f23d588d18) PM-10242 PM-10243 PM-10244 PM-10245 PM-10246: Welcome carousel - [`6d8a4a4`](https://github.com/bitwarden/android/commit/6d8a4a4e5a933ec45749401c8735053704ec0e93) Feedback updates and added feature flag - [`a246689`](https://github.com/bitwarden/android/commit/a246689d4716b774644fbb2c587d1f08d3929ed7) Update - [`95b7cdf`](https://github.com/bitwarden/android/commit/95b7cdf51d4d85376b63f6e0043cc698454a9d16) Don't force refresh - [`b73bcbf`](https://github.com/bitwarden/android/commit/b73bcbf6a67e9cc625cb88b277199034265e0f75) Use synchronous feature flag - [`f518bea`](https://github.com/bitwarden/android/commit/f518beaabc89c6776a087293cd785f5be0228463) Fix test - [`61c5bdb`](https://github.com/bitwarden/android/commit/61c5bdb9323dc7b3f7954fac4e3274b3dd0ff4ed) Rename title string resources - [`27f33bf`](https://github.com/bitwarden/android/commit/27f33bf0eed44b874007d0e5fe20ad7bce2999b0) I promise I'm literate... ### 📊 Changes **19 files changed** (+1026 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+9 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt` (+32 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt` (+272 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModel.kt` (+161 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+15 -3) ➕ `app/src/main/res/drawable/welcome_1.xml` (+73 -0) ➕ `app/src/main/res/drawable/welcome_2.xml` (+58 -0) ➕ `app/src/main/res/drawable/welcome_3.xml` (+46 -0) ➕ `app/src/main/res/drawable/welcome_4.xml` (+56 -0) 📝 `app/src/main/res/values/strings.xml` (+8 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+20 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt` (+124 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModelTest.kt` (+95 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt` (+9 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+29 -4) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> [PM-10242](https://bitwarden.atlassian.net/browse/PM-10242) [PM-10243](https://bitwarden.atlassian.net/browse/PM-10243) [PM-10244](https://bitwarden.atlassian.net/browse/PM-10244) [PM-10245](https://bitwarden.atlassian.net/browse/PM-10245) [PM-10246](https://bitwarden.atlassian.net/browse/PM-10246) ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Add a new welcome carousel before the landing page for users who are opening the app for the first time (ie, who have never logged in or created an account on the device before) NOTE: For now, the old landing page and create account views are shown, just to make sure the buttons work. It looks a little strange, but the auth flow will be updated more in later tickets. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/3cd6c5a9-3c59-4163-9f0e-c287f4b35b04" /> | <video src="https://github.com/user-attachments/assets/92120951-7df9-40f9-bf97-e9eb33a1959c" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-10242]: https://bitwarden.atlassian.net/browse/PM-10242?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-10243]: https://bitwarden.atlassian.net/browse/PM-10243?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-10244]: https://bitwarden.atlassian.net/browse/PM-10244?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-10245]: https://bitwarden.atlassian.net/browse/PM-10245?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-10246]: https://bitwarden.atlassian.net/browse/PM-10246?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:42:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?