github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3654] [MERGED] [PM-9833] Allow passkey deletion edit view #4316

New Issue
Closed
opened 2025-11-26 23:42:49 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:42:49 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3654
Author: @LRNcardozoWDF
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/8/2024
Merged by: @LRNcardozoWDF

Base: main ← Head: vault/PM-9833

📝 Commits (10+)

  • 5834e68 PM-9833 Add button to remove passkey
  • a5ae753 Merge branch 'main' into vault/PM-9833
  • ef07699 Merge branch 'main' into vault/PM-9833
  • eab3391 PM-9833 Minor refactor
  • 52921ec Merge branch 'main' into vault/PM-9833
  • 7de169a PM-9833 Minor refactor
  • 00d971d PM-9833 Minor refactor
  • 094612a PM-9833 Fix PR comments
  • 3b6d36c Merge branch 'main' into vault/PM-9833
  • 14b6709 PM-9833 Fix PR comments

📊 Changes

8 files changed (+233 additions, -47 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+18 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+16 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt (+8 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+2 -1)
📝 app/src/main/res/values/strings.xml (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+52 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+81 -45)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt (+54 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9833

📔 Objective

Allow deletion of passkey from edit view. Voice over will announce when the passkey is removed.

📸 Screenshots

🎞️ Recordings

  • Permission: Can edit

https://github.com/user-attachments/assets/55474fb5-128c-4a08-bfe1-237c57c614c9

  • Permission: Can edit except passwords

https://github.com/user-attachments/assets/45c915de-7329-42c3-84ee-84c42a5e6bd9

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3654 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/8/2024 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `main` ← **Head:** `vault/PM-9833` --- ### 📝 Commits (10+) - [`5834e68`](https://github.com/bitwarden/android/commit/5834e6837d2654a77b78c70b15cb2e508180fb53) PM-9833 Add button to remove passkey - [`a5ae753`](https://github.com/bitwarden/android/commit/a5ae753ba1e1cef67b3abcc2ae54d69a31264717) Merge branch 'main' into vault/PM-9833 - [`ef07699`](https://github.com/bitwarden/android/commit/ef0769935e5767f23275d16fb759e2c0ac35e533) Merge branch 'main' into vault/PM-9833 - [`eab3391`](https://github.com/bitwarden/android/commit/eab3391bb64107e3ce31593fb56f063bec0303bf) PM-9833 Minor refactor - [`52921ec`](https://github.com/bitwarden/android/commit/52921ec93fe351acd6eb1d19601b8829f5600940) Merge branch 'main' into vault/PM-9833 - [`7de169a`](https://github.com/bitwarden/android/commit/7de169ab573139ff2f9ecd95e8007eff2dd4859f) PM-9833 Minor refactor - [`00d971d`](https://github.com/bitwarden/android/commit/00d971df13e466a48c6b77bc8aca8ce17ff8e6a9) PM-9833 Minor refactor - [`094612a`](https://github.com/bitwarden/android/commit/094612a85ddf3f8bec08869e7ddf44f233522eb1) PM-9833 Fix PR comments - [`3b6d36c`](https://github.com/bitwarden/android/commit/3b6d36cbdd2a6250ded68101dbe2c300eda696a1) Merge branch 'main' into vault/PM-9833 - [`14b6709`](https://github.com/bitwarden/android/commit/14b67090d71133e045fe8aabbbc5c57f53e2a086) PM-9833 Fix PR comments ### 📊 Changes **8 files changed** (+233 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+18 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+16 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt` (+8 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+2 -1) 📝 `app/src/main/res/values/strings.xml` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+52 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+81 -45) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensionsTest.kt` (+54 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-9833 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Allow deletion of passkey from edit view. Voice over will announce when the passkey is removed. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> <img src="https://github.com/user-attachments/assets/dc98406d-66d7-42e7-97fa-302293fa8245" width="300" height="600"> ## 🎞️ Recordings * Permission: Can edit https://github.com/user-attachments/assets/55474fb5-128c-4a08-bfe1-237c57c614c9 * Permission: Can edit except passwords https://github.com/user-attachments/assets/45c915de-7329-42c3-84ee-84c42a5e6bd9 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:42:49 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4316
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?