github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3648] [MERGED] [PM-9410] Filter matching FIDO 2 credentials after vault unlock #4311

New Issue
Closed
opened 2025-11-26 23:42:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:42:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3648
Author: @SaintPatrck
Created: 7/29/2024
Status: ✅ Merged
Merged: 7/30/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-9410/fido2-attest-selected-cred

📝 Commits (10+)

  • 689f438 [PM-9410] Implement FIDO 2 Get Credentials completion
  • 792d0ba [PM-9410] Introduce FIDO 2 Get Credentials Request special circumstance
  • b65a1db Merge branch 'refs/heads/PM-9410/special-circumstance-fido2-get-creds' into PM-9410/fido2-attest-selected-cred
  • da57aef [PM-9410] Unlock vault and return matching FIDO 2 credentials
  • 7b7766a Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9410/fido2-attest-selected-cred
  • bd369fa Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9410/fido2-attest-selected-cred
  • 21432a7 Make Fido2CompletionManagerImpl dependent on IntentManager
  • f517e7b Make Fido2CompletionManagerImpl dependent on IntentManager
  • 9d2e123 Merge branch 'refs/heads/PM-9410/fido2-get-creds-completion' into PM-9410/fido2-attest-selected-cred
  • 907fc3e Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9410/fido2-attest-selected-cred

📊 Changes

16 files changed (+369 additions, -23 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+9 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsRequest.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PasskeyAttestationOptions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt (+33 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManager.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerUnsupportedApiImpl.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+3 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+4 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+66 -3)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+39 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtilsTest.kt (+103 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt (+6 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+11 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+82 -0)

📄 Description

🎟️ Tracking

PM-9410

📔 Objective

After unlocking the user's vault for a FIDO Get Credentials request, filter the active vault for matching credentials and clear the existing authentication action.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3648 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 7/30/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-9410/fido2-attest-selected-cred` --- ### 📝 Commits (10+) - [`689f438`](https://github.com/bitwarden/android/commit/689f438c863a70c525e357195397dbfa6e02db1e) [PM-9410] Implement FIDO 2 Get Credentials completion - [`792d0ba`](https://github.com/bitwarden/android/commit/792d0ba68a84803e5dc2f7877bd0c47d74cb6cc2) [PM-9410] Introduce FIDO 2 Get Credentials Request special circumstance - [`b65a1db`](https://github.com/bitwarden/android/commit/b65a1db1fd5d7ddddce04a2cb88c10e18257a5cb) Merge branch 'refs/heads/PM-9410/special-circumstance-fido2-get-creds' into PM-9410/fido2-attest-selected-cred - [`da57aef`](https://github.com/bitwarden/android/commit/da57aefba738e20ec509e8910ab61a9d5f4c1fe0) [PM-9410] Unlock vault and return matching FIDO 2 credentials - [`7b7766a`](https://github.com/bitwarden/android/commit/7b7766a26e1ae168358ec97674c9f4201e7ffb11) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9410/fido2-attest-selected-cred - [`bd369fa`](https://github.com/bitwarden/android/commit/bd369fabf09cd95f436fac1ce554316eac231eef) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9410/fido2-attest-selected-cred - [`21432a7`](https://github.com/bitwarden/android/commit/21432a7bd63ba97f206d9d65e9e6868eff843e1a) Make Fido2CompletionManagerImpl dependent on IntentManager - [`f517e7b`](https://github.com/bitwarden/android/commit/f517e7be275743aa06783a65d0ef17532fa0b634) Make Fido2CompletionManagerImpl dependent on IntentManager - [`9d2e123`](https://github.com/bitwarden/android/commit/9d2e1236a86edf61667b417abb5a7f8573f27ba8) Merge branch 'refs/heads/PM-9410/fido2-get-creds-completion' into PM-9410/fido2-attest-selected-cred - [`907fc3e`](https://github.com/bitwarden/android/commit/907fc3e8046a317b4243fe7a0c9eb82697c26a06) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-9410/fido2-attest-selected-cred ### 📊 Changes **16 files changed** (+369 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+9 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsRequest.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PasskeyAttestationOptions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt` (+33 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManager.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerUnsupportedApiImpl.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+3 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+4 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+66 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+39 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtilsTest.kt` (+103 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt` (+6 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+11 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+82 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-9410 ## 📔 Objective After unlocking the user's vault for a FIDO Get Credentials request, filter the active vault for matching credentials and clear the existing authentication action. ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:42:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?