[PR #3639] [MERGED] [PM-9410] Implement FIDO 2 Get Credentials completion #4306

New Issue

GiteaMirror · 2025-11-26T23:42:40-06:00

GiteaMirror commented

2025-11-26 23:42:40 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3639
Author: @SaintPatrck
Created: 7/26/2024
Status: ✅ Merged
Merged: 7/29/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-9410/fido2-get-creds-completion

📝 Commits (2)

689f438 [PM-9410] Implement FIDO 2 Get Credentials completion
f517e7b Make Fido2CompletionManagerImpl dependent on IntentManager

📊 Changes

7 files changed (+283 additions, -5 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialResult.kt (+26 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManager.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt (+57 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerUnsupportedApiImpl.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+3 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt (+186 -2)

📄 Description

🎟️ Tracking

PM-9410

📔 Objective

Implement the completion process for FIDO 2 Get Credentials operation. This process packages any matching credentials into PublicKeyCredentialEntry objects and delivers them to the OS before finishing the activity.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3639 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/26/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-9410/fido2-get-creds-completion` --- ### 📝 Commits (2) - [`689f438`](https://github.com/bitwarden/android/commit/689f438c863a70c525e357195397dbfa6e02db1e) [PM-9410] Implement FIDO 2 Get Credentials completion - [`f517e7b`](https://github.com/bitwarden/android/commit/f517e7be275743aa06783a65d0ef17532fa0b634) Make Fido2CompletionManagerImpl dependent on IntentManager ### 📊 Changes **7 files changed** (+283 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialResult.kt` (+26 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManager.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt` (+57 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerUnsupportedApiImpl.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+3 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt` (+186 -2) </details> ### 📄 Description ## 🎟️ Tracking PM-9410 ## 📔 Objective Implement the completion process for FIDO 2 Get Credentials operation. This process packages any matching credentials into PublicKeyCredentialEntry objects and delivers them to the OS before finishing the activity. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:42:40 -06:00

GiteaMirror closed this issue