github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5312] [MERGED] [PM-22389] GitHub Release workflow supports releasing BWPM and BWA #42755

New Issue
Closed
opened 2026-04-23 21:25:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 21:25:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5312
Author: @vvolkgang
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/9/2025
Merged by: @vvolkgang

Base: main ← Head: monorepo/release-workflow

📝 Commits (10+)

  • a19e5eb Draft - add support for releasing BWPM and BWA. Replaces release creation action with gh cli
  • 3b042be Replace gh api calls with gh release
  • d7e9ed7 Merge branch 'main' into monorepo/release-workflow
  • 0746d60 Fix error output
  • 2c1a6b3 Handle Build workflow
  • 2ccca60 Refactor error messages
  • 07944ed Fetch version name and number from run logs
  • 826bb2b Removing version and release state inputs to simplify the workflow
  • 00cd503 Remove branch protection input, we'll keep the branch name based approach.
  • e3597b9 Remove commented code

📊 Changes

1 file changed (+133 additions, -63 deletions)

View changed files

📝 .github/workflows/github-release.yml (+133 -63)

📄 Description

🎟️ Tracking

PM-22389

📔 Objective

Update GitHub Release creation workflow to support releasing Password Manager and Authenticator apps.

While at it:

  1. Replaced third-party action and GitHub API call with GH CLI gh release commands
  2. When creating a draft release previously, tags would be incorrectly named (e.g. "untagged-9878879870"). Transitioning to GH CLI fixed this
  3. Version name and number don't need to be provided anymore, it's retrieved from the build run logs
  4. Simplified the workflow by removing inputs, aligning with the process we've been following
  5. Improved the Run summary with release management instructions (previously added in bitwarden/ios repo)

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5312 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/9/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `monorepo/release-workflow` --- ### 📝 Commits (10+) - [`a19e5eb`](https://github.com/bitwarden/android/commit/a19e5eb210dc5bf1bb241e141b58607b15f09542) Draft - add support for releasing BWPM and BWA. Replaces release creation action with gh cli - [`3b042be`](https://github.com/bitwarden/android/commit/3b042bef1ef6ece8330d5c7c411bc154477853f1) Replace gh api calls with gh release - [`d7e9ed7`](https://github.com/bitwarden/android/commit/d7e9ed7947b169bc8e3d7efddc6b4b433e882b67) Merge branch 'main' into monorepo/release-workflow - [`0746d60`](https://github.com/bitwarden/android/commit/0746d607b0b50ae6208f269577a72b20a7a255d5) Fix error output - [`2c1a6b3`](https://github.com/bitwarden/android/commit/2c1a6b38e7fe8e48195d285c0898eefbbe9c31e1) Handle Build workflow - [`2ccca60`](https://github.com/bitwarden/android/commit/2ccca602b8e834fef8091eb244f5d6467349da56) Refactor error messages - [`07944ed`](https://github.com/bitwarden/android/commit/07944edbc6816133a34e17f3d71d183de2d8e66f) Fetch version name and number from run logs - [`826bb2b`](https://github.com/bitwarden/android/commit/826bb2bdace9341563565ce14873d3cccc28d766) Removing version and release state inputs to simplify the workflow - [`00cd503`](https://github.com/bitwarden/android/commit/00cd503d3049bc5eb6c165d89d5fdb06705a0210) Remove branch protection input, we'll keep the branch name based approach. - [`e3597b9`](https://github.com/bitwarden/android/commit/e3597b9c74448b6bf05d326a04ed8f6ee4462a03) Remove commented code ### 📊 Changes **1 file changed** (+133 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/github-release.yml` (+133 -63) </details> ### 📄 Description ## 🎟️ Tracking PM-22389 ## 📔 Objective Update GitHub Release creation workflow to support releasing Password Manager and Authenticator apps. While at it: 1. Replaced third-party action and GitHub API call with GH CLI `gh release` commands 1. When creating a draft release previously, tags would be incorrectly named (e.g. "untagged-9878879870"). Transitioning to GH CLI fixed this 1. Version name and number don't need to be provided anymore, it's retrieved from the build run logs 1. Simplified the workflow by removing inputs, aligning with the process we've been following 1. Improved the Run summary with release management instructions (previously added in bitwarden/ios repo) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 21:25:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#42755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?