github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3599] PM-9532 pt. 1 small refactor of login success steps #4275

New Issue
Closed
opened 2025-11-26 23:42:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:42:17 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3599

State: closed
Merged: Yes

This is a small refactor of some of the Login common code, the end goal of PM-9532 will be to propagate any non API (read SDK) errors that can occur in the login flow (such as unlocking the vault). The change here moves all the unlock vault code to the top of the call stack in the handleLoginCommonSuccess function.

The goal of this PR is to isolate this logic reordering to allow for regression testing without any other changes related to propagating the error message.

**Original Pull Request:** https://github.com/bitwarden/android/pull/3599 **State:** closed **Merged:** Yes --- This is a small refactor of some of the Login common code, the end goal of [PM-9532](https://bitwarden.atlassian.net/browse/PM-9532) will be to propagate any non API (read SDK) errors that can occur in the login flow (such as unlocking the vault). The change here moves all the unlock vault code to the top of the call stack in the `handleLoginCommonSuccess` function. The goal of this PR is to isolate this logic reordering to allow for regression testing without any other changes related to propagating the error message. [PM-9532]: https://bitwarden.atlassian.net/browse/PM-9532?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
GiteaMirror added the pull-request label 2025-11-26 23:42:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?