github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-12 05:27:02 -05:00
Code Issues 2.3k Packages Projects Releases 128 Wiki Activity

[PR #3954] [MERGED] BITAU-104 Implement BridgeService #41645

New Issue
Closed
opened 2026-04-23 20:24:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 20:24:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3954
Author: @ahaisting-livefront
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @ahaisting-livefront

Base: main ← Head: implement-bridge-service

📝 Commits (7)

  • 66d0ef9 BITAU-104 Implement BridgeService
  • c94f350 update ordering on BridgeRepository
  • eb79ab3 update chaining in BridgeRepositoryImpl
  • e9863c2 unmockkstatic in BridgeServiceProcessorTest
  • 94c78b9 use assertTrue in BridgeRepositoryTest
  • 121a762 update class doc for BridgeRepository
  • 8b7f522 use assertTrue

📊 Changes

10 files changed (+861 additions, -32 deletions)

View changed files

📝 app/libs/bridge-0.1.0-SNAPSHOT-release.aar (+0 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorImpl.kt (+64 -16)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/repository/BridgeRepository.kt (+25 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/repository/BridgeRepositoryImpl.kt (+119 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/di/PlatformRepositoryModule.kt (+23 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorTest.kt (+178 -9)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/repository/BridgeRepositoryTest.kt (+438 -0)
📝 bridge/src/main/aidl/com/bitwarden/bridge/IBridgeService.aidl (+1 -1)
📝 bridge/src/main/java/com/bitwarden/bridge/util/EncryptionUtils.kt (+8 -6)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-104

📔 Objective

The goal if this PR is to setup the core syncing logic within the BridgeServiceProcessor, and really, namely, the syncAccounts call.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3954 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `implement-bridge-service` --- ### 📝 Commits (7) - [`66d0ef9`](https://github.com/bitwarden/android/commit/66d0ef9919bf60b1a9e3e1528e3e019a7c5bfd4e) BITAU-104 Implement BridgeService - [`c94f350`](https://github.com/bitwarden/android/commit/c94f35057e01b8fa0ead0a25401afe2721e00eaf) update ordering on BridgeRepository - [`eb79ab3`](https://github.com/bitwarden/android/commit/eb79ab3e6e833f0de254b6e8fdc2840390426b8e) update chaining in BridgeRepositoryImpl - [`e9863c2`](https://github.com/bitwarden/android/commit/e9863c266fb2e2f6e132bad665ae34182c8e9649) unmockkstatic in BridgeServiceProcessorTest - [`94c78b9`](https://github.com/bitwarden/android/commit/94c78b9a54bcb2e83518c9053b5c0137ede1c700) use assertTrue in BridgeRepositoryTest - [`121a762`](https://github.com/bitwarden/android/commit/121a762c79d99b01de03b1c78f0f4cebd7e88d96) update class doc for BridgeRepository - [`8b7f522`](https://github.com/bitwarden/android/commit/8b7f522455e05bdf19503834fc5c629834737c90) use assertTrue ### 📊 Changes **10 files changed** (+861 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `app/libs/bridge-0.1.0-SNAPSHOT-release.aar` (+0 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorImpl.kt` (+64 -16) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/BridgeRepository.kt` (+25 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/BridgeRepositoryImpl.kt` (+119 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/di/PlatformRepositoryModule.kt` (+23 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorTest.kt` (+178 -9) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/BridgeRepositoryTest.kt` (+438 -0) 📝 `bridge/src/main/aidl/com/bitwarden/bridge/IBridgeService.aidl` (+1 -1) 📝 `bridge/src/main/java/com/bitwarden/bridge/util/EncryptionUtils.kt` (+8 -6) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-104 ## 📔 Objective The goal if this PR is to setup the core syncing logic within the `BridgeServiceProcessor`, and really, namely, the `syncAccounts` call. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 20:24:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#41645
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?