github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3397] [MERGED] BIT-2439: Handle invalid patterns when processing regular expression matching #41288

New Issue
Closed
opened 2026-04-23 20:05:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 20:05:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3397
Author: @david-livefront
Created: 7/2/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @david-livefront

Base: main ← Head: BIT-2439-regular-expression-match-crash

📝 Commits (1)

  • 543b42d BIT-2439: Handle invalid patterns when processing regular expression matching

📊 Changes

3 files changed (+38 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerImpl.kt (+4 -3)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/util/RegexUtils.kt (+16 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/util/RegexUtilsTest.kt (+18 -0)

📄 Description

🎟️ Tracking

BIT-2439

📔 Objective

This PR fixes a crash that can happen when a user enters a regular expression that is not a valid pattern.

Fatal Exception: java.util.regex.PatternSyntaxException: Unrecognized backslash escape sequence in pattern near index 4
.*\maj\-soul\.com.*
    ^
       at com.android.icu.util.regex.PatternNative.compileImpl(PatternNative.java)
       at com.android.icu.util.regex.PatternNative.<init>(PatternNative.java:53)
       at com.android.icu.util.regex.PatternNative.create(PatternNative.java:49)
       at java.util.regex.Pattern.compile(Pattern.java:3533)
       at java.util.regex.Pattern.<init>(Pattern.java:1419)
       at java.util.regex.Pattern.compile(Pattern.java:947)
       at kotlin.text.Regex.<init>(Regex.kt:91)
       at com.x8bit.bitwarden.data.platform.manager.ciphermatching.CipherMatchingManagerImplKt.checkForMatch(CipherMatchingManagerImpl.kt:215)
       at com.x8bit.bitwarden.data.platform.manager.ciphermatching.CipherMatchingManagerImplKt.checkForCipherMatch(CipherMatchingManagerImpl.kt:158)

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3397 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/2/2024 **Status:** ✅ Merged **Merged:** 7/3/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `BIT-2439-regular-expression-match-crash` --- ### 📝 Commits (1) - [`543b42d`](https://github.com/bitwarden/android/commit/543b42dbd01baf468d55358d3f41b85efe0b8439) BIT-2439: Handle invalid patterns when processing regular expression matching ### 📊 Changes **3 files changed** (+38 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerImpl.kt` (+4 -3) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/util/RegexUtils.kt` (+16 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/util/RegexUtilsTest.kt` (+18 -0) </details> ### 📄 Description ## 🎟️ Tracking [BIT-2439](https://livefront.atlassian.net/browse/BIT-2439) ## 📔 Objective This PR fixes a crash that can happen when a user enters a regular expression that is not a valid pattern. ``` Fatal Exception: java.util.regex.PatternSyntaxException: Unrecognized backslash escape sequence in pattern near index 4 .*\maj\-soul\.com.* ^ at com.android.icu.util.regex.PatternNative.compileImpl(PatternNative.java) at com.android.icu.util.regex.PatternNative.<init>(PatternNative.java:53) at com.android.icu.util.regex.PatternNative.create(PatternNative.java:49) at java.util.regex.Pattern.compile(Pattern.java:3533) at java.util.regex.Pattern.<init>(Pattern.java:1419) at java.util.regex.Pattern.compile(Pattern.java:947) at kotlin.text.Regex.<init>(Regex.kt:91) at com.x8bit.bitwarden.data.platform.manager.ciphermatching.CipherMatchingManagerImplKt.checkForMatch(CipherMatchingManagerImpl.kt:215) at com.x8bit.bitwarden.data.platform.manager.ciphermatching.CipherMatchingManagerImplKt.checkForCipherMatch(CipherMatchingManagerImpl.kt:158) ``` ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 20:05:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#41288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?