github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3260] [PM-8372] Generate higher minimum number/special character values #4121

New Issue
Closed
opened 2025-11-26 23:40:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:40:46 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3260

State: closed
Merged: No

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes https://github.com/bitwarden/mobile/issues/3259

Code changes

Context: see desktop blob and mobile blob for comparison.

  • src/Core/Pages/Generator/GeneratorPage.xaml: Change max value of MinNumber and MinSpecial (5 -> 9)

I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix.

**Original Pull Request:** https://github.com/bitwarden/android/pull/3260 **State:** closed **Merged:** No --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes https://github.com/bitwarden/mobile/issues/3259 ## Code changes Context: see [desktop blob](https://github.com/bitwarden/clients/blob/main/apps%2Fdesktop%2Fsrc%2Fapp%2Ftools%2Fgenerator.component.html#L282-L305) and [mobile blob](https://github.com/bitwarden/mobile/blob/main/src%2FCore%2FPages%2FGenerator%2FGeneratorPage.xaml#L497-L525) for comparison. * `src/Core/Pages/Generator/GeneratorPage.xaml`: Change max value of `MinNumber` and `MinSpecial` (5 -> 9) I have built and tested this on Android 13 and 14, armeabi-v7a and arm64-v8a. I do not have the ability to test an iOS build, but it should be an equally easy fix.
GiteaMirror added the pull-request label 2025-11-26 23:40:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?