github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 16:46:10 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3198] [MERGED] [PM-7749] Add Fido2 (non) privileged apps verification specific messages #41177

New Issue
Closed
opened 2026-04-23 19:58:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:58:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3198
Author: @fedemkr
Created: 4/26/2024
Status: ✅ Merged
Merged: 4/26/2024
Merged by: @fedemkr

Base: main ← Head: mobiletf/pm-7749/add-fido2-verification-specific-messages

📝 Commits (1)

  • e556d3c PM-7746 Added specific validation messages for (non) privileged apps validation on Fido2 flows. Also fixed typo on "privileged" and updated UT

📊 Changes

9 files changed (+167 additions, -48 deletions)

View changed files

📝 src/App/App.csproj (+1 -1)
📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+35 -17)
📝 src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+12 -1)
📝 src/App/Resources/Raw/fido2_privileged_allow_list.json (+0 -0)
➕ src/Core/Exceptions/ValidationException.cs (+10 -0)
📝 src/Core/Resources/Localization/AppResources.Designer.cs (+45 -0)
📝 src/Core/Resources/Localization/AppResources.resx (+15 -0)
📝 src/Core/Services/AssetLinksService.cs (+29 -11)
📝 test/Core.Test/Services/AssetLinksServiceTest.cs (+20 -18)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add Fido2 (non) privileged apps verification specific messages

Code changes

  • CredentialHelpers: Added handling for verification specific messages. Also implemented throwing ValidationException on the validation flows to send the correct message to display to the user based on which error occurred.
  • AssetLinksService: Implemented throwing ValidationException on the validation flows to send the correct message to display to the user based on which error occurred.
  • CredentialProviderActivity: Added handling for verification specific messages.
  • Others: Fixed typo priviliged => privileged

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3198 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/26/2024 **Status:** ✅ Merged **Merged:** 4/26/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `main` ← **Head:** `mobiletf/pm-7749/add-fido2-verification-specific-messages` --- ### 📝 Commits (1) - [`e556d3c`](https://github.com/bitwarden/android/commit/e556d3c99c75833d67633e724ae8c551fc5a3240) PM-7746 Added specific validation messages for (non) privileged apps validation on Fido2 flows. Also fixed typo on "privileged" and updated UT ### 📊 Changes **9 files changed** (+167 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+1 -1) 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+35 -17) 📝 `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+12 -1) 📝 `src/App/Resources/Raw/fido2_privileged_allow_list.json` (+0 -0) ➕ `src/Core/Exceptions/ValidationException.cs` (+10 -0) 📝 `src/Core/Resources/Localization/AppResources.Designer.cs` (+45 -0) 📝 `src/Core/Resources/Localization/AppResources.resx` (+15 -0) 📝 `src/Core/Services/AssetLinksService.cs` (+29 -11) 📝 `test/Core.Test/Services/AssetLinksServiceTest.cs` (+20 -18) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add Fido2 (non) privileged apps verification specific messages ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CredentialHelpers:** Added handling for verification specific messages. Also implemented throwing `ValidationException` on the validation flows to send the correct message to display to the user based on which error occurred. * **AssetLinksService:** Implemented throwing `ValidationException` on the validation flows to send the correct message to display to the user based on which error occurred. * **CredentialProviderActivity:** Added handling for verification specific messages. * **Others:** Fixed typo `priviliged` => `privileged` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:58:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#41177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?