github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3079] [MERGED] [PM-6706] Implement User Verification maximum attempts on Pin and reprompt #41100

New Issue
Closed
opened 2026-04-23 19:54:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:54:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3079
Author: @fedemkr
Created: 3/13/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: vault/pm-6706/mp-and-pin-max-attempts

📝 Commits (3)

  • 51fe79b PM-6706 Add maximum attempts to UV with MP and with PIN
  • f56e881 Merged feature/maui-migration-passkeys to vault/pm-6706/mp-and-pin-max-attempts
  • d3c763e Merge branch 'feature/maui-migration-passkeys' into vault/pm-6706/mp-and-pin-max-attempts

📊 Changes

3 files changed (+62 additions, -31 deletions)

View changed files

📝 src/Core/Abstractions/IUserVerificationMediatorService.cs (+1 -1)
📝 src/Core/Services/UserVerification/Fido2UserVerificationRequiredServiceStrategy.cs (+1 -1)
📝 src/Core/Services/UserVerification/UserVerificationMediatorService.cs (+60 -29)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement User Verification maximum attempts on Pin and reprompt

Code changes

Implemented verify with attempts to allow a maximum of 5 tries on master password and PIN user verification.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3079 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/13/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6706/mp-and-pin-max-attempts` --- ### 📝 Commits (3) - [`51fe79b`](https://github.com/bitwarden/android/commit/51fe79bdf9b77db00168fb4301918d0d4fedb594) PM-6706 Add maximum attempts to UV with MP and with PIN - [`f56e881`](https://github.com/bitwarden/android/commit/f56e88186ffa82fc10a1a7b9871efe7d37af6730) Merged feature/maui-migration-passkeys to vault/pm-6706/mp-and-pin-max-attempts - [`d3c763e`](https://github.com/bitwarden/android/commit/d3c763efdcd0a540df53898d020a9404ce9813e2) Merge branch 'feature/maui-migration-passkeys' into vault/pm-6706/mp-and-pin-max-attempts ### 📊 Changes **3 files changed** (+62 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IUserVerificationMediatorService.cs` (+1 -1) 📝 `src/Core/Services/UserVerification/Fido2UserVerificationRequiredServiceStrategy.cs` (+1 -1) 📝 `src/Core/Services/UserVerification/UserVerificationMediatorService.cs` (+60 -29) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implement User Verification maximum attempts on Pin and reprompt ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Implemented verify with attempts to allow a maximum of 5 tries on master password and PIN user verification. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:54:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#41100
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?