github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 17:16:20 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2951] [MERGED] [PM-5731] Create C# WebAuthn authenticator to support maui apps #40996

New Issue
Closed
opened 2026-04-23 19:47:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:47:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2951
Author: @coroiu
Created: 1/23/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: PM-5731-create-c-web-authn-authenticator-to-support-maui-apps

📝 Commits (10+)

  • f9b4e30 [PM-5731] feat: implement get assertion params object
  • 32c2f2a [PM-5731] feat: add first test
  • cc89b6a [PM-5731] feat: add rp mismatch test
  • 66a01e3 [PM-5731] feat: ask for credentials when found
  • a08466d [PM-5731] feat: find discoverable credentials
  • dbe4110 [PM-5731] feat: add tests for successful UV requests
  • 378551e [PM-5731] feat: add user does not consent test
  • 0dc281e [PM-5731] feat: check for UV when reprompt is active
  • ad80def [PM-5731] fix: tests a bit, needed some additional "arrange" steps
  • d0e0f0e [PM-5731] feat: add support for counter

📊 Changes

45 files changed (+3166 additions, -21 deletions)

View changed files

📝 src/Core/Abstractions/ICryptoFunctionService.cs (+1 -0)
➕ src/Core/Abstractions/IFido2AuthenticatorService.cs (+12 -0)
➕ src/Core/Abstractions/IFido2ClientService.cs (+35 -0)
➕ src/Core/Abstractions/IFido2GetAssertionUserInterface.cs (+18 -0)
➕ src/Core/Abstractions/IFido2MakeCredentialUserInterface.cs (+37 -0)
➕ src/Core/Abstractions/IFido2UserInterface.cs (+12 -0)
📝 src/Core/Core.csproj (+1 -0)
📝 src/Core/Models/View/Fido2CredentialView.cs (+21 -1)
➕ src/Core/Services/Fido2AuthenticatorService.cs (+456 -0)
➕ src/Core/Services/Fido2ClientService.cs (+252 -0)
📝 src/Core/Services/PclCryptoFunctionService.cs (+1 -0)
📝 src/Core/Utilities/CoreHelpers.cs (+39 -0)
➕ src/Core/Utilities/Fido2/AuthenticatorSelectionCriteria.cs (+18 -0)
➕ src/Core/Utilities/Fido2/Fido2AlgorithmIdentifier.cs (+8 -0)
➕ src/Core/Utilities/Fido2/Fido2AuthenticatorDiscoverableCredentialMetadata.cs (+16 -0)
➕ src/Core/Utilities/Fido2/Fido2AuthenticatorException.cs (+37 -0)
📝 src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionParams.cs (+16 -2)
📝 src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionResult.cs (+10 -2)
➕ src/Core/Utilities/Fido2/Fido2AuthenticatorMakeCredentialParams.cs (+53 -0)
➕ src/Core/Utilities/Fido2/Fido2AuthenticatorMakeCredentialResult.cs (+16 -0)

...and 25 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2951 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 1/23/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `PM-5731-create-c-web-authn-authenticator-to-support-maui-apps` --- ### 📝 Commits (10+) - [`f9b4e30`](https://github.com/bitwarden/android/commit/f9b4e30b0b8830265c15e71a3e44183a547da3ce) [PM-5731] feat: implement get assertion params object - [`32c2f2a`](https://github.com/bitwarden/android/commit/32c2f2aac4d969800bb7bf714438618a00ca90c7) [PM-5731] feat: add first test - [`cc89b6a`](https://github.com/bitwarden/android/commit/cc89b6a5d54eb102c0821da6e99f10a08e28853e) [PM-5731] feat: add rp mismatch test - [`66a01e3`](https://github.com/bitwarden/android/commit/66a01e30d38bd10d8751691e459737bab30117e4) [PM-5731] feat: ask for credentials when found - [`a08466d`](https://github.com/bitwarden/android/commit/a08466d220f38eafefcb7063b2620e2cd75bf5cc) [PM-5731] feat: find discoverable credentials - [`dbe4110`](https://github.com/bitwarden/android/commit/dbe411002763973c60db160e2f9c5f48f2d7beb1) [PM-5731] feat: add tests for successful UV requests - [`378551e`](https://github.com/bitwarden/android/commit/378551e2d55338fb1ab73ddf2c5aa95dfb8d7329) [PM-5731] feat: add user does not consent test - [`0dc281e`](https://github.com/bitwarden/android/commit/0dc281edc140ebc9f180fc29a01ebdb6b5f591d8) [PM-5731] feat: check for UV when reprompt is active - [`ad80def`](https://github.com/bitwarden/android/commit/ad80defa4093e8f582f22d284db6e2e5650e9d11) [PM-5731] fix: tests a bit, needed some additional "arrange" steps - [`d0e0f0e`](https://github.com/bitwarden/android/commit/d0e0f0ecdbc2e068d51dab0311065f3ce606de5a) [PM-5731] feat: add support for counter ### 📊 Changes **45 files changed** (+3166 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/ICryptoFunctionService.cs` (+1 -0) ➕ `src/Core/Abstractions/IFido2AuthenticatorService.cs` (+12 -0) ➕ `src/Core/Abstractions/IFido2ClientService.cs` (+35 -0) ➕ `src/Core/Abstractions/IFido2GetAssertionUserInterface.cs` (+18 -0) ➕ `src/Core/Abstractions/IFido2MakeCredentialUserInterface.cs` (+37 -0) ➕ `src/Core/Abstractions/IFido2UserInterface.cs` (+12 -0) 📝 `src/Core/Core.csproj` (+1 -0) 📝 `src/Core/Models/View/Fido2CredentialView.cs` (+21 -1) ➕ `src/Core/Services/Fido2AuthenticatorService.cs` (+456 -0) ➕ `src/Core/Services/Fido2ClientService.cs` (+252 -0) 📝 `src/Core/Services/PclCryptoFunctionService.cs` (+1 -0) 📝 `src/Core/Utilities/CoreHelpers.cs` (+39 -0) ➕ `src/Core/Utilities/Fido2/AuthenticatorSelectionCriteria.cs` (+18 -0) ➕ `src/Core/Utilities/Fido2/Fido2AlgorithmIdentifier.cs` (+8 -0) ➕ `src/Core/Utilities/Fido2/Fido2AuthenticatorDiscoverableCredentialMetadata.cs` (+16 -0) ➕ `src/Core/Utilities/Fido2/Fido2AuthenticatorException.cs` (+37 -0) 📝 `src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionParams.cs` (+16 -2) 📝 `src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionResult.cs` (+10 -2) ➕ `src/Core/Utilities/Fido2/Fido2AuthenticatorMakeCredentialParams.cs` (+53 -0) ➕ `src/Core/Utilities/Fido2/Fido2AuthenticatorMakeCredentialResult.cs` (+16 -0) _...and 25 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:47:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40996
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?