github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 12:58:36 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2796] [MERGED] [PM-4092] Fix vault timeout policies on new Settings #40900

New Issue
Closed
opened 2026-04-23 19:42:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:42:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2796
Author: @fedemkr
Created: 9/26/2023
Status: ✅ Merged
Merged: 9/26/2023
Merged by: @fedemkr

Base: vault/pm-2658/feature-settings-reorganization ← Head: vault/pm-4092/disable-tap-on-policy-settings

📝 Commits (2)

  • 40bc5e4 PM-4092 Fix vault timeout policy on settings for disabling controls and reset timeout when surpassing maximum
  • dc642fc PM-4092 Removed testing hardcoding of policy data

📊 Changes

1 file changed (+10 additions, -6 deletions)

View changed files

📝 src/App/Pages/Settings/SecuritySettingsPageViewModel.cs (+10 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Disable vault timeout action on policy set and reset to maximum when the user enters a timeout that surpasses the policy maximum.

Code changes

  • SecuritySettingsViewModel: Applied policies to disable control and reset to maximum timeout depending on the policy and input of the user.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2796 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 9/26/2023 **Status:** ✅ Merged **Merged:** 9/26/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `vault/pm-2658/feature-settings-reorganization` ← **Head:** `vault/pm-4092/disable-tap-on-policy-settings` --- ### 📝 Commits (2) - [`40bc5e4`](https://github.com/bitwarden/android/commit/40bc5e4eb7b52ced13fce82cddd7e8b02d69d058) PM-4092 Fix vault timeout policy on settings for disabling controls and reset timeout when surpassing maximum - [`dc642fc`](https://github.com/bitwarden/android/commit/dc642fc385b0fa78b5dc051476d8fdee0c898060) PM-4092 Removed testing hardcoding of policy data ### 📊 Changes **1 file changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/SecuritySettingsPageViewModel.cs` (+10 -6) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Disable vault timeout action on policy set and reset to maximum when the user enters a timeout that surpasses the policy maximum. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **SecuritySettingsViewModel:** Applied policies to disable control and reset to maximum timeout depending on the policy and input of the user. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:42:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40900
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?