github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2672] [MERGED] [PM-3342] Not you button not working #40813

New Issue
Closed
opened 2026-04-23 19:37:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:37:41 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2672
Author: @andrebispo5
Created: 8/8/2023
Status: ✅ Merged
Merged: 8/8/2023
Merged by: @andrebispo5

Base: feature/pm-1029-tde-login ← Head: auth/pm-3342-logout

📝 Commits (1)

  • 435451d [PM-3342] Not you button logs user out.

📊 Changes

6 files changed (+6 additions, -14 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginApproveDevicePage.xaml (+1 -1)
📝 src/App/Pages/Accounts/LoginApproveDevicePage.xaml.cs (+0 -9)
📝 src/App/Pages/Accounts/LoginApproveDeviceViewModel.cs (+5 -1)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+0 -1)
📝 src/iOS.Extension/LoadingViewController.cs (+0 -1)
📝 src/iOS.ShareExtension/LoadingViewController.cs (+0 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Android: Tapping "Not you?" From the decryption-options screen sends user into a loop.

Code changes

Instead of Popping the modal and go back, just call logout and send the user to the homepage.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2672 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/8/2023 **Status:** ✅ Merged **Merged:** 8/8/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/pm-1029-tde-login` ← **Head:** `auth/pm-3342-logout` --- ### 📝 Commits (1) - [`435451d`](https://github.com/bitwarden/android/commit/435451d139304ea0905a39e81a8b175b99e1b951) [PM-3342] Not you button logs user out. ### 📊 Changes **6 files changed** (+6 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginApproveDevicePage.xaml` (+1 -1) 📝 `src/App/Pages/Accounts/LoginApproveDevicePage.xaml.cs` (+0 -9) 📝 `src/App/Pages/Accounts/LoginApproveDeviceViewModel.cs` (+5 -1) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+0 -1) 📝 `src/iOS.Extension/LoadingViewController.cs` (+0 -1) 📝 `src/iOS.ShareExtension/LoadingViewController.cs` (+0 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Android: Tapping "Not you?" From the `decryption-options` screen sends user into a loop. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Instead of Popping the modal and go back, just call logout and send the user to the homepage. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:37:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40813