github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2630] [MERGED] [PM-3092] Clarify argon2 ios autofill warning #40783

New Issue
Closed
opened 2026-04-23 19:36:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:36:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2630
Author: @quexten
Created: 7/19/2023
Status: ✅ Merged
Merged: 8/7/2023
Merged by: @mpbw2

Base: master ← Head: feature/clarify-ios-argon2-warning

📝 Commits (3)

  • 5303706 Clarify argon2 ios warning
  • 70ffa62 Update Argon2 insufficient memory warning message
  • 404c7b3 Merge branch 'master' into feature/clarify-ios-argon2-warning

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/App/Resources/AppResources.resx (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

#2560 Added a warning for iOS users since iOS autofill might crash with too high memory usage caused by argon2. This PR clarifies the message by adding biometric unlock as another option to resolve the issue. When using biometrics to unlock, the KDF is circumvented entirely and thus the issue does not occur (without the user changing their KDF settings).

Code changes

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2630 **Author:** [@quexten](https://github.com/quexten) **Created:** 7/19/2023 **Status:** ✅ Merged **Merged:** 8/7/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature/clarify-ios-argon2-warning` --- ### 📝 Commits (3) - [`5303706`](https://github.com/bitwarden/android/commit/5303706871b237218324ff1a6f3005b192aa3b7b) Clarify argon2 ios warning - [`70ffa62`](https://github.com/bitwarden/android/commit/70ffa62db3173748fe8e4b9bf55c74501a8acc11) Update Argon2 insufficient memory warning message - [`404c7b3`](https://github.com/bitwarden/android/commit/404c7b31b9265d0639d79574fa6e33835766a847) Merge branch 'master' into feature/clarify-ios-argon2-warning ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Resources/AppResources.resx` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective #2560 Added a warning for iOS users since iOS autofill might crash with too high memory usage caused by argon2. This PR clarifies the message by adding biometric unlock as another option to resolve the issue. When using biometrics to unlock, the KDF is circumvented entirely and thus the issue does not occur (without the user changing their KDF settings). ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * [AppResources.resx](https://github.com/bitwarden/mobile/compare/master...quexten:feature/clarify-ios-argon2-warning?expand=1#diff-ff9e117a0afa143ff240c20739b24823fe76ac8d59e6d06a626fd269e7be73de) Clarify the warning ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:36:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40783
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?