github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2550] [MERGED] [PM-1798] Improve ScreenReader when adding a cipher #40725

New Issue
Closed
opened 2026-04-23 19:33:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:33:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2550
Author: @fedemkr
Created: 5/29/2023
Status: ✅ Merged
Merged: 6/5/2023
Merged by: @fedemkr

Base: master ← Head: PM-1798-fix-android-talkback-new-cipher

📝 Commits (1)

  • 97a921f PM-1798 Added accessibility names on entries on cipher add

📊 Changes

5 files changed (+119 additions, -49 deletions)

View changed files

📝 src/App/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml (+3 -1)
📝 src/App/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml (+3 -1)
📝 src/App/Pages/Vault/CipherAddEditPage.xaml (+83 -29)
📝 src/App/Resources/AppResources.Designer.cs (+27 -18)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The entries when adding a cipher should have a name assigned for screen reader.

Code changes

  • All files: Added the entires to the accessible tree and set their accessible name. I couldn't use LabeledBy feature of Xamarin Forms because it doesn't work on iOS as stated in the docs.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2550 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/29/2023 **Status:** ✅ Merged **Merged:** 6/5/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-1798-fix-android-talkback-new-cipher` --- ### 📝 Commits (1) - [`97a921f`](https://github.com/bitwarden/android/commit/97a921f1b47af574ccc02a8ea1931fe3301b5f6e) PM-1798 Added accessibility names on entries on cipher add ### 📊 Changes **5 files changed** (+119 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml` (+3 -1) 📝 `src/App/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml` (+3 -1) 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml` (+83 -29) 📝 `src/App/Resources/AppResources.Designer.cs` (+27 -18) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The entries when adding a cipher should have a name assigned for screen reader. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **All files:** Added the entires to the accessible tree and set their accessible name. I couldn't use `LabeledBy` feature of Xamarin Forms because it doesn't work on iOS as stated in the [docs](https://learn.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/accessibility/automation-properties#automationpropertieslabeledby). ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:33:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40725
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?