github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2411] [MERGED] [PM-1386] Fix OTP Data Issuer and Account name being set correctly #40641

New Issue
Closed
opened 2026-04-23 19:28:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:28:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2411
Author: @fedemkr
Created: 3/9/2023
Status: ✅ Merged
Merged: 3/9/2023
Merged by: @fedemkr

Base: master ← Head: bug/PM-1386-otp-handling-issuer-not-set-correctly

📝 Commits (1)

  • a319c85 PM-1386 Fix otp data issuer and account name being set correctly

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/Core/Utilities/OtpData.cs (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The Issuer and Account name should be set correctly on the OtpData from the OTP uri

Code changes

  • OTPData: Fix set Issuer and Account name from the label. The correct order is first the Issuer and then the AccountName

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2411 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/9/2023 **Status:** ✅ Merged **Merged:** 3/9/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/PM-1386-otp-handling-issuer-not-set-correctly` --- ### 📝 Commits (1) - [`a319c85`](https://github.com/bitwarden/android/commit/a319c85d7622a37dbfc9dba4b8684b7e500bfec3) PM-1386 Fix otp data issuer and account name being set correctly ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Utilities/OtpData.cs` (+2 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The Issuer and Account name should be set correctly on the `OtpData` from the OTP uri ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **OTPData:** Fix set Issuer and Account name from the label. The correct order is first the `Issuer` and then the `AccountName` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:28:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?