github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3127] [PM-7186] Fallback to password list on exception #4041

New Issue
Closed
opened 2025-11-26 23:39:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:56 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3127

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials.
We should fallback to passwords in this scenario.

Code changes

  • LoginListViewController.cs: Added fallback reload scenario
  • Context.cs: Added new boolean Flag to distinguish the fallback scenario

Screenshots

Fallback Password List if exception occurs.

Fallback password list

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3127 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials. We should fallback to passwords in this scenario. ## Code changes * **LoginListViewController.cs:** Added fallback reload scenario * **Context.cs:** Added new boolean Flag to distinguish the fallback scenario ## Screenshots <!--Required for any UI changes. Delete if not applicable--> Fallback Password List if exception occurs. <img width="1024" alt="Fallback password list" src="https://github.com/bitwarden/mobile/assets/2824952/970e2b91-5260-478e-afd6-41a93c00aa08"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?