github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3085] [PM-6852 ] Fix F-Droid build constant #4016

New Issue
Closed
opened 2025-11-26 23:39:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:40 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3085

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix CI/CD to for F-Droid build to pass the constant as it's supposed to so AppCenter and Firebase are removed from the final apk.

There seems to be an issue when building for Release configuration where the :/p CustomConstants=FDROID is not added to the DefineConstants or replaced at some point, causing the corresponding packages not to be removed from the build. So the approach was changed by not passing the parameter in the command and enabling the constant in the Directory.Build.props

Code changes

  • Directory.Build.props: Added a comment for the FDROID custom constant.
  • build.yml: Enabled FDROID custom constant on the Directory.Build.props by replacing the commented line with the uncommented version of it.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3085 **State:** closed **Merged:** Yes --- ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix CI/CD to for F-Droid build to pass the constant as it's supposed to so AppCenter and Firebase are removed from the final apk. There seems to be an issue when building for `Release` configuration where the `:/p CustomConstants=FDROID` is not added to the `DefineConstants` or replaced at some point, causing the corresponding packages not to be removed from the build. So the approach was changed by not passing the parameter in the command and enabling the constant in the `Directory.Build.props` ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Directory.Build.props:** Added a comment for the FDROID custom constant. * **build.yml:** Enabled FDROID custom constant on the `Directory.Build.props` by replacing the commented line with the uncommented version of it. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4016
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?