github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1340] [MERGED] Hide email address in Sends #39932

New Issue
Closed
opened 2026-04-23 18:50:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 18:50:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1340
Author: @eliykat
Created: 3/26/2021
Status: ✅ Merged
Merged: 3/29/2021
Merged by: @mpbw2

Base: master ← Head: send-hide-email

📝 Commits (6)

  • 74df017 Add HideEmail model properties and locale strings
  • 28200a2 Fix UI strings
  • 6104c0a Add HideEmail to SendService
  • a6a8dea Add HideEmail option to UI
  • 706c202 Tidy up declarations
  • 8663f89 Add Bitwarden Send translation warning

📊 Changes

12 files changed (+96 additions, -0 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+26 -0)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+20 -0)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+7 -0)
📝 src/App/Utilities/AppHelpers.cs (+20 -0)
📝 src/Core/Enums/PolicyType.cs (+1 -0)
📝 src/Core/Models/Data/SendData.cs (+2 -0)
📝 src/Core/Models/Domain/Send.cs (+2 -0)
📝 src/Core/Models/Request/SendRequest.cs (+2 -0)
📝 src/Core/Models/Response/SendResponse.cs (+1 -0)
📝 src/Core/Models/View/SendView.cs (+2 -0)
📝 src/Core/Services/SendService.cs (+1 -0)

📄 Description

Objective

Allow the creator of a Send to hide their email address from the recipient.

See the web PR and server PR for more info and discussion.

Code changes

  • add "Hide my email address from recipients" toggle slider to the Send AddEdit page
  • check and enforce new Send Options Policy > which can disable this new feature (disableHideEmail)
  • add banner at the top of the Send AddEdit page if Send Options policy is in effect

Screenshots

Screen Shot 2021-03-26 at 3 44 29 pm

Screen Shot 2021-03-26 at 3 44 42 pm

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1340 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 3/26/2021 **Status:** ✅ Merged **Merged:** 3/29/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `send-hide-email` --- ### 📝 Commits (6) - [`74df017`](https://github.com/bitwarden/android/commit/74df017306da152437b1e1b274d4494d9915f766) Add HideEmail model properties and locale strings - [`28200a2`](https://github.com/bitwarden/android/commit/28200a2f57e12f8335153127393e43bdc62c3bfa) Fix UI strings - [`6104c0a`](https://github.com/bitwarden/android/commit/6104c0a2bee7f414154ba37cc082a92d555c34f3) Add HideEmail to SendService - [`a6a8dea`](https://github.com/bitwarden/android/commit/a6a8deac1d437752ce7d8cfa40904a7e6b0965b9) Add HideEmail option to UI - [`706c202`](https://github.com/bitwarden/android/commit/706c2022e935fa57c557fcf9234c31b50024f5e4) Tidy up declarations - [`8663f89`](https://github.com/bitwarden/android/commit/8663f8947270182b8477328d1335726cbd80ef19) Add Bitwarden Send translation warning ### 📊 Changes **12 files changed** (+96 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+26 -0) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+20 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+7 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+20 -0) 📝 `src/Core/Enums/PolicyType.cs` (+1 -0) 📝 `src/Core/Models/Data/SendData.cs` (+2 -0) 📝 `src/Core/Models/Domain/Send.cs` (+2 -0) 📝 `src/Core/Models/Request/SendRequest.cs` (+2 -0) 📝 `src/Core/Models/Response/SendResponse.cs` (+1 -0) 📝 `src/Core/Models/View/SendView.cs` (+2 -0) 📝 `src/Core/Services/SendService.cs` (+1 -0) </details> ### 📄 Description ## Objective Allow the creator of a Send to hide their email address from the recipient. See the [web PR](https://github.com/bitwarden/web/pull/895) and [server PR](https://github.com/bitwarden/server/pull/1234) for more info and discussion. ## Code changes * add "Hide my email address from recipients" toggle slider to the Send AddEdit page * check and enforce new Send Options Policy > which can disable this new feature (`disableHideEmail`) * add banner at the top of the Send AddEdit page if Send Options policy is in effect ## Screenshots ![Screen Shot 2021-03-26 at 3 44 29 pm](https://user-images.githubusercontent.com/31796059/112587912-34d48880-8e4a-11eb-9d09-a218e415a6c2.png) ![Screen Shot 2021-03-26 at 3 44 42 pm](https://user-images.githubusercontent.com/31796059/112587919-3900a600-8e4a-11eb-93e5-653ddbba733f.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 18:50:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#39932
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?