github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #3049] [PM-6539] Fix Autofill Extension TDE without MP flow #3990

New Issue
Closed
opened 2025-11-26 23:39:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:19 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3049

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix Autofill iOS Extension when using TDE without MP flow.

Note: I also fixed one NRE on the state migration from 6 to 7, also same happening on Generator view on iOS extension. Additionally, WebAuthenticator was copied and adapted from MAUI Essentials to get the current UIWindow as in Xamarin Essentials.

Code changes

  • BaseLockPasswordViewController: Updating PromptSSO view controller creation to be like in MAUI.
  • LoginAddViewController: Fixed generator view controller creation to be like in MAUI.
  • StateMigrationService: Fix NRE if state is null
  • LoginSSOViewModel: Fix to use workaround for iOS Extension on the WebAuthenticator
  • WebAuthenticator: MAUI Essentials copy of WebAuthenticator adapted to get the current UIWIndow as it was being done in Xamarin Essentials to work in iOS Extensions.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3049 **State:** closed **Merged:** Yes --- ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix Autofill iOS Extension when using TDE without MP flow. _Note: I also fixed one NRE on the state migration from 6 to 7, also same happening on Generator view on iOS extension. Additionally, `WebAuthenticator` was copied and adapted from MAUI Essentials to get the current `UIWindow` as in Xamarin Essentials._ ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **BaseLockPasswordViewController:** Updating PromptSSO view controller creation to be like in MAUI. * **LoginAddViewController:** Fixed generator view controller creation to be like in MAUI. * **StateMigrationService:** Fix NRE if `state` is `null` * **LoginSSOViewModel:** Fix to use workaround for iOS Extension on the `WebAuthenticator` * **WebAuthenticator:** MAUI Essentials copy of `WebAuthenticator` adapted to get the current `UIWIndow` as it was being done in Xamarin Essentials to work in iOS Extensions. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?