github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1110] [MERGED] Support for storing multiple biometric integrity states for iOS #39842

New Issue
Closed
opened 2026-04-23 18:45:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 18:45:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1110
Author: @mpbw2
Created: 10/7/2020
Status: ✅ Merged
Merged: 10/7/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-iosbioext

📝 Commits (2)

  • 58311b1 support for storing multiple biometric integrity states for iOS
  • 16b9eaa remove unused var & save new extension bio state upon password validation

📊 Changes

6 files changed (+35 additions, -12 deletions)

View changed files

📝 src/Android/Services/BiometricService.cs (+4 -2)
📝 src/Core/Abstractions/IBiometricService.cs (+2 -2)
📝 src/iOS.Autofill/LockPasswordViewController.cs (+3 -1)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+10 -1)
📝 src/iOS.Core/Services/BiometricService.cs (+13 -5)
📝 src/iOS.Extension/LockPasswordViewController.cs (+3 -1)

📄 Description

iOS extensions are returning a different biometric state from the main app (derived from bundle ID):

https://developer.apple.com/forums/thread/70570

This PR adds support for performing integrity validation based on the source of the query (extension vs app). Unfortunately this means both the extension(s) and the main app will have to re-enter the password for verification after a change in biometric integrity, independent of each other. Not an ideal experience, but since an integrity change shouldn't happen frequently I believe this is our best course of action.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1110 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/7/2020 **Status:** ✅ Merged **Merged:** 10/7/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-iosbioext` --- ### 📝 Commits (2) - [`58311b1`](https://github.com/bitwarden/android/commit/58311b10183c0ea7be1d71e476319db880974328) support for storing multiple biometric integrity states for iOS - [`16b9eaa`](https://github.com/bitwarden/android/commit/16b9eaa2e5dda763bcb329773d68f7675e8acd15) remove unused var & save new extension bio state upon password validation ### 📊 Changes **6 files changed** (+35 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/BiometricService.cs` (+4 -2) 📝 `src/Core/Abstractions/IBiometricService.cs` (+2 -2) 📝 `src/iOS.Autofill/LockPasswordViewController.cs` (+3 -1) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+10 -1) 📝 `src/iOS.Core/Services/BiometricService.cs` (+13 -5) 📝 `src/iOS.Extension/LockPasswordViewController.cs` (+3 -1) </details> ### 📄 Description iOS extensions are returning a different biometric state from the main app (derived from bundle ID): https://developer.apple.com/forums/thread/70570 This PR adds support for performing integrity validation based on the source of the query (extension vs app). Unfortunately this means both the extension(s) and the main app will have to re-enter the password for verification after a change in biometric integrity, independent of each other. Not an ideal experience, but since an integrity change shouldn't happen frequently I believe this is our best course of action. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 18:45:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#39842
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?