github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3042] [PM-5916] Fix for incorrect fonts in fingerprint phrases #3984

New Issue
Closed
opened 2025-11-26 23:39:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:14 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3042

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fingerprint phrases are being shown with the incorrect font

Code changes

The correct font is set for MonoLabel but apparently they are not set when using FormattedText.
Changing to Text instead fixes the issue. (FormattedText doesn't really seem to be needed in this scenario)
I applied this to other MonoLabel in the app that had the same issue.

  • LoginPasswordlessPage.xaml: Changed FormattedText to Text
  • LoginPasswordlessRequestPage.xaml: Changed FormattedText to Text
  • LoginPasswordlessRequestsListPage.xaml: Changed FormattedText to Text

Screenshots

Before After
Before After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3042 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fingerprint phrases are being shown with the incorrect font ## Code changes The correct font is set for MonoLabel but apparently they are not set when using FormattedText. Changing to Text instead fixes the issue. (FormattedText doesn't really seem to be needed in this scenario) I applied this to other MonoLabel in the app that had the same issue. * **LoginPasswordlessPage.xaml:** Changed `FormattedText` to `Text` * **LoginPasswordlessRequestPage.xaml:** Changed `FormattedText` to `Text` * **LoginPasswordlessRequestsListPage.xaml:** Changed `FormattedText` to `Text` ## Screenshots Before | After :-------------------------:|:-------------------------: ![Before](https://github.com/bitwarden/mobile/assets/2824952/f4530f16-cf8a-4bf2-807b-04a63290f035) | ![After](https://github.com/bitwarden/mobile/assets/2824952/8a1ca494-99e0-4b7f-b980-eb48acd76ec9) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3984
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?