github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3026] [PM-6301] Fix for pending login view breaks after closing one request #3971

New Issue
Closed
opened 2025-11-26 23:39:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:06 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3026

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Currently on iOS there are still Layout issues related with the RefreshView.
These seem to be caused by the IsRefreshing being set to true on RefreshAsync which the RefreshView seems to use to trigger the RefreshCommand again. This duplicate execution causes layout issues on iOS.

Code changes

Removing IsRefreshing=true fixes the issue. The only worry is that the busy indicator would not appear, but this doesn't seem to be a problem because when doing PullToRefresh the RefreshView changes IsRefreshing and shows the indicator.
For the other situations where we execute RefreshAsync the LoginPasswordlessRequestsListPage.xaml.cs takes care of the busy indicator.

  • LoginPasswordlessRequestsListViewModel.cs: Removed IsRefreshing=true

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3026 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Currently on iOS there are still Layout issues related with the RefreshView. These seem to be caused by the IsRefreshing being set to true on RefreshAsync which the RefreshView seems to use to trigger the RefreshCommand again. This duplicate execution causes layout issues on iOS. ## Code changes Removing `IsRefreshing=true` fixes the issue. The only worry is that the busy indicator would not appear, but this doesn't seem to be a problem because when doing PullToRefresh the RefreshView changes IsRefreshing and shows the indicator. For the other situations where we execute RefreshAsync the `LoginPasswordlessRequestsListPage.xaml.cs` takes care of the busy indicator. * **LoginPasswordlessRequestsListViewModel.cs:** Removed `IsRefreshing=true` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3971
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?