github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #4166] Generator: Unnecessary linebreaks for long passwords #38999

New Issue
Closed
opened 2026-04-23 17:28:40 -05:00 by GiteaMirror · 11 comments
GiteaMirror commented 2026-04-23 17:28:40 -05:00
Owner
Copy Link

Originally created by @Jan-Koll on GitHub (Oct 25, 2024).
Original GitHub issue: https://github.com/bitwarden/android/issues/4166

Bitwarden Beta

  • I'm using the new native Bitwarden Beta app and I'm aware that legacy .NET app bugs should be reported in bitwarden/mobile

Steps To Reproduce

  1. Go to 'Generator'
  2. Increase password length via the slider

Expected Result

The generated password fills the available horizontal space.

Actual Result

Unnecessary linebreaks are added almost every other line. This results in a lot of vertical space that is required.

Screenshots or Videos

Screenshot_2024-10-25-19-02-32-79_edf9c6c5202cf0aae90965d36a8e7fc4

Additional Context

No response

Build Version

2024.9.0 (19209)

Environment Details

Android 12, default system font size

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Originally created by @Jan-Koll on GitHub (Oct 25, 2024). Original GitHub issue: https://github.com/bitwarden/android/issues/4166 ### Bitwarden Beta - [X] I'm using the new native Bitwarden Beta app and I'm aware that legacy .NET app bugs should be reported in [bitwarden/mobile](https://github.com/bitwarden/mobile) ### Steps To Reproduce 1. Go to 'Generator' 2. Increase password length via the slider ### Expected Result The generated password fills the available horizontal space. ### Actual Result Unnecessary linebreaks are added almost every other line. This results in a lot of vertical space that is required. ### Screenshots or Videos ![Screenshot_2024-10-25-19-02-32-79_edf9c6c5202cf0aae90965d36a8e7fc4](https://github.com/user-attachments/assets/a8827af9-364f-4007-9719-e88c2b8f9344) ### Additional Context _No response_ ### Build Version 2024.9.0 (19209) ### Environment Details Android 12, default system font size ### Issue Tracking Info - [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
GiteaMirror added the bug label 2026-04-23 17:28:40 -05:00
GiteaMirror commented 2026-04-23 17:28:43 -05:00
Author
Owner
Copy Link

@bitwarden-bot commented on GitHub (Oct 25, 2024):

Thank you for your report! We've added this to our internal board for review.
ID: PM-14044

<!-- gh-comment-id:2438377035 --> @bitwarden-bot commented on GitHub (Oct 25, 2024): Thank you for your report! We've added this to our internal board for review. ID: PM-14044
GiteaMirror commented 2026-04-23 17:28:45 -05:00
Author
Owner
Copy Link

@jtodddd commented on GitHub (Oct 28, 2024):

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

<!-- gh-comment-id:2441838977 --> @jtodddd commented on GitHub (Oct 28, 2024): Hi there, Thank you for your report! I was able to reproduce this issue, and I have flagged this to our engineering team. If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these. Thanks once again!
GiteaMirror commented 2026-04-23 17:28:45 -05:00
Author
Owner
Copy Link

@differsthecat commented on GitHub (Oct 30, 2024):

This was fixed by this PR, closing 🙂

<!-- gh-comment-id:2448419903 --> @differsthecat commented on GitHub (Oct 30, 2024): This was fixed by [this PR](https://github.com/bitwarden/android/pull/4187), closing 🙂
GiteaMirror commented 2026-04-23 17:28:47 -05:00
Author
Owner
Copy Link

@vinnyperella commented on GitHub (Nov 1, 2024):

This was fixed by this PR, closing 🙂

This is still an issue in 2024.10.2 what version will the fix be implemented in?

Screenshot_20241101-024000.png

<!-- gh-comment-id:2451383129 --> @vinnyperella commented on GitHub (Nov 1, 2024): > This was fixed by [this PR](https://github.com/bitwarden/android/pull/4187), closing 🙂 This is still an issue in 2024.10.2 what version will the fix be implemented in? ![Screenshot_20241101-024000.png](https://github.com/user-attachments/assets/c81d8e09-8a10-4934-853b-973b197c65d1)
GiteaMirror commented 2026-04-23 17:28:49 -05:00
Author
Owner
Copy Link

@Jan-Koll commented on GitHub (Nov 4, 2024):

I agree, the issue is still there in the latest beta (Version: 2024.10.2 (19397)). Since the changes were merged 3 days ago, my guess is that the next release will include the fix.

<!-- gh-comment-id:2454010040 --> @Jan-Koll commented on GitHub (Nov 4, 2024): I agree, the issue is still there in the latest beta (Version: 2024.10.2 (19397)). Since the changes were merged 3 days ago, my guess is that the next release will include the fix.
GiteaMirror commented 2026-04-23 17:28:50 -05:00
Author
Owner
Copy Link

@frabera commented on GitHub (Nov 6, 2024):

It is still present for me on 2024.11.2

<!-- gh-comment-id:2460910816 --> @frabera commented on GitHub (Nov 6, 2024): It is still present for me on 2024.11.2
GiteaMirror commented 2026-04-23 17:28:51 -05:00
Author
Owner
Copy Link

@frabera commented on GitHub (Nov 11, 2024):

Just an update, up until 11.2 it was showing regular linebreaks (alternative lines with just 2 characters) as shown in the posted screenshot. In 11.3 and 11.4 it is showing random linebreaks as in the "before" video of the posted pull request #4187.

<!-- gh-comment-id:2468416737 --> @frabera commented on GitHub (Nov 11, 2024): Just an update, up until 11.2 it was showing regular linebreaks (alternative lines with just 2 characters) as shown in the posted screenshot. In 11.3 and 11.4 it is showing random linebreaks as in the "before" video of the posted pull request #4187.
GiteaMirror commented 2026-04-23 17:28:52 -05:00
Author
Owner
Copy Link

@Jan-Koll commented on GitHub (Nov 12, 2024):

@differsthecat @jtodddd Maybe this issue could be opened again, since the problem doesn't seem to be resolved.

Just an update, up until 11.2 it was showing regular linebreaks (alternative lines with just 2 characters) as shown in the posted screenshot. In 11.3 and 11.4 it is showing random linebreaks as in the "before" video of the posted pull request #4187.

Interesting. I am on 11.3 currently and I always get 3 characters every other line.

By the way, I just noticed this is also the case for the passphrase generation (so not only password generation).

<!-- gh-comment-id:2469821255 --> @Jan-Koll commented on GitHub (Nov 12, 2024): @differsthecat @jtodddd Maybe this issue could be opened again, since the problem doesn't seem to be resolved. > Just an update, up until 11.2 it was showing regular linebreaks (alternative lines with just 2 characters) as shown in the posted screenshot. In 11.3 and 11.4 it is showing random linebreaks as in the "before" video of the posted pull request #4187. Interesting. I am on 11.3 currently and I always get 3 characters every other line. By the way, I just noticed this is also the case for the passphrase generation (so not only password generation).
GiteaMirror commented 2026-04-23 17:28:53 -05:00
Author
Owner
Copy Link

@vinnyperella commented on GitHub (Nov 14, 2024):

This was fixed by this PR, closing 🙂

@differsthecat This has not been fixed.

<!-- gh-comment-id:2475143319 --> @vinnyperella commented on GitHub (Nov 14, 2024): > This was fixed by [this PR](https://github.com/bitwarden/android/pull/4187), closing 🙂 @differsthecat This has not been fixed.
GiteaMirror commented 2026-04-23 17:28:55 -05:00
Author
Owner
Copy Link

@Jan-Koll commented on GitHub (Nov 20, 2024):

In 2024.11.6 (19499) it is fixed.

<!-- gh-comment-id:2489547662 --> @Jan-Koll commented on GitHub (Nov 20, 2024): In 2024.11.6 (19499) it is fixed.
GiteaMirror commented 2026-04-23 17:28:57 -05:00
Author
Owner
Copy Link

@vinnyperella commented on GitHub (Jan 14, 2025):

In 2024.11.6 (19499) it is fixed.

This still looks to be an issue in the Bitwarden native Android app 2025.1.0. Sometimes it lines up correctly but other times it does what I've shown below. Another issue was opened for this: https://github.com/bitwarden/android/issues/4394

Image

<!-- gh-comment-id:2590462965 --> @vinnyperella commented on GitHub (Jan 14, 2025): > In 2024.11.6 (19499) it is fixed. This still looks to be an issue in the Bitwarden native Android app 2025.1.0. Sometimes it lines up correctly but other times it does what I've shown below. Another issue was opened for this: https://github.com/bitwarden/android/issues/4394 ![Image](https://github.com/user-attachments/assets/7046965e-b6dc-4c58-aca3-02e81b941bb4)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#38999
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?