github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2942] [PM-5760] Add autofill support for Spin Browser #3898

New Issue
Closed
opened 2025-11-26 23:38:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:38:22 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2942

State: closed
Merged: No

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Bitwarden autofill doesn't work in Spin Browser. More details in this issue: https://github.com/bitwarden/mobile/issues/2848.
Spin Browser is a browser based on Firefox for mobile that adds built-in internet filtering functionality.
Website: https://spinsafebrowser.com
Google Play: https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser

Code changes

  • AutofillHelpers.cs: Added "com.nationaledtech.spinbrowser",
  • AccessibilityHelpers.cs: Added new Browser("com.nationaledtech.spinbrowser", "mozac_browser_toolbar_url_view"),
  • autofillservice.xml Added <compatibility-package android:name="com.nationaledtech.spinbrowser" android:maxLongVersionCode="10000000000"/>
  • Some trailing whitespace was also auto-removed from AutofillHelpers.cs and AccessibilityHelpers.cs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2942 **State:** closed **Merged:** No --- ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective Bitwarden autofill doesn't work in Spin Browser. More details in this issue: https://github.com/bitwarden/mobile/issues/2848. Spin Browser is a browser based on Firefox for mobile that adds built-in internet filtering functionality. Website: https://spinsafebrowser.com Google Play: https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AutofillHelpers.cs**: Added `"com.nationaledtech.spinbrowser",` * **AccessibilityHelpers.cs:** Added `new Browser("com.nationaledtech.spinbrowser", "mozac_browser_toolbar_url_view"),` * **autofillservice.xml** Added `<compatibility-package android:name="com.nationaledtech.spinbrowser" android:maxLongVersionCode="10000000000"/>` * Some trailing whitespace was also auto-removed from `AutofillHelpers.cs` and `AccessibilityHelpers.cs` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:38:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3898
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?