github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #3406] When you copy an item, the copied value will be displayed below #38894

New Issue
Closed
opened 2026-04-23 17:09:57 -05:00 by GiteaMirror · 15 comments
GiteaMirror commented 2026-04-23 17:09:57 -05:00
Owner
Copy Link

Originally created by @likevi9528 on GitHub (Jul 5, 2024).
Original GitHub issue: https://github.com/bitwarden/android/issues/3406

Bitwarden Beta

  • I'm using the new native Bitwarden Beta app and I'm aware that legacy .NET app bugs should be reported in bitwarden/mobile

Steps To Reproduce

  1. Click the 'COPY' icons.

Expected Result

It should show ‘Value or Password copied’ instead of the copied value

Actual Result

Display the copied value

Screenshots or Videos

The first video is the Beta APP, the second is the Old APP.

https://github.com/bitwarden/android/assets/81839775/fe4527c5-fc9c-4b3e-b530-37c1661eaee5

https://github.com/bitwarden/android/assets/81839775/13b2d05b-2812-4d0b-aa63-ae5f5eca173f

Additional Context

Displaying passwords or hidden fields can pose a security risk.

Build Version

2024.7.0

Environment Details

  • Device: Redmi k30
  • OS: Android 12

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Originally created by @likevi9528 on GitHub (Jul 5, 2024). Original GitHub issue: https://github.com/bitwarden/android/issues/3406 ### Bitwarden Beta - [X] I'm using the new native Bitwarden Beta app and I'm aware that legacy .NET app bugs should be reported in [bitwarden/mobile](https://github.com/bitwarden/mobile) ### Steps To Reproduce 1. Click the 'COPY' icons. ### Expected Result It should show ‘Value or Password copied’ instead of the copied value ### Actual Result Display the copied value ### Screenshots or Videos The first video is the Beta APP, the second is the Old APP. https://github.com/bitwarden/android/assets/81839775/fe4527c5-fc9c-4b3e-b530-37c1661eaee5 https://github.com/bitwarden/android/assets/81839775/13b2d05b-2812-4d0b-aa63-ae5f5eca173f ### Additional Context Displaying passwords or hidden fields can pose a security risk. ### Build Version 2024.7.0 ### Environment Details - Device: Redmi k30 - OS: Android 12 ### Issue Tracking Info - [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
GiteaMirror added the bug label 2026-04-23 17:09:58 -05:00
GiteaMirror commented 2026-04-23 17:10:03 -05:00
Author
Owner
Copy Link

@lakshay6907 commented on GitHub (Jul 14, 2024):

Is this issue still open?

<!-- gh-comment-id:2227188075 --> @lakshay6907 commented on GitHub (Jul 14, 2024): Is this issue still open?
GiteaMirror commented 2026-04-23 17:10:04 -05:00
Author
Owner
Copy Link

@likevi9528 commented on GitHub (Jul 20, 2024):

Is this issue still open?

Yes, the problem still exists in the latest version 2024.7.2(1899).

<!-- gh-comment-id:2241056301 --> @likevi9528 commented on GitHub (Jul 20, 2024): > Is this issue still open? Yes, the problem still exists in the latest version 2024.7.2(1899).
GiteaMirror commented 2026-04-23 17:10:06 -05:00
Author
Owner
Copy Link

@lakshay6907 commented on GitHub (Jul 21, 2024):

Getting the error "401 Unauthorized" error indicates that the Maven repository is requiring authentication. Cann you help me with this

<!-- gh-comment-id:2241541507 --> @lakshay6907 commented on GitHub (Jul 21, 2024): Getting the error "401 Unauthorized" error indicates that the Maven repository is requiring authentication. Cann you help me with this
GiteaMirror commented 2026-04-23 17:10:07 -05:00
Author
Owner
Copy Link

@likevi9528 commented on GitHub (Jul 21, 2024):

Getting the error "401 Unauthorized" error indicates that the Maven repository is requiring authentication. Cann you help me with this

Sorry, this probably involves some of Bitwarden's secrets, so you should submit a PR for community verification.

<!-- gh-comment-id:2241551000 --> @likevi9528 commented on GitHub (Jul 21, 2024): > Getting the error "401 Unauthorized" error indicates that the Maven repository is requiring authentication. Cann you help me with this Sorry, this probably involves some of Bitwarden's secrets, so you should submit a PR for community verification.
GiteaMirror commented 2026-04-23 17:10:08 -05:00
Author
Owner
Copy Link

@lakshay6907 commented on GitHub (Jul 21, 2024):

Okay.

<!-- gh-comment-id:2241552001 --> @lakshay6907 commented on GitHub (Jul 21, 2024): Okay.
GiteaMirror commented 2026-04-23 17:10:09 -05:00
Author
Owner
Copy Link

@qwexter commented on GitHub (Jul 22, 2024):

Hi! I've reserched this issue too!
I got confused by one moment - we use same API to copy data everywhere even for strings like notes, titles, app's version etc.
And it's bring an issue at API 33 and above. All copied texts are masked in preview (Sorry for external link, there is the example of masking non sensitive data).
I think we should:

  1. use masking with sensitive data only
  2. change an approach and show in taosts fileds title or item time, not data. Like "Password copied", "Notes copied" etc.

I understand that its requires some work and ready to do it If general approach is OK to bitwarden team.

<!-- gh-comment-id:2243408722 --> @qwexter commented on GitHub (Jul 22, 2024): Hi! I've reserched this issue too! I got confused by one moment - we use same API to copy data everywhere even for strings like notes, titles, app's version etc. And it's bring an issue at API 33 and above. All copied texts are masked in preview (Sorry for external link, [there is](https://www.youtube.com/live/DssaVNwosEY?feature=shared&t=4028) the example of masking non sensitive data). I think we should: 1. use masking with sensitive data only 2. change an approach and show in taosts fileds title or item time, not data. Like "Password copied", "Notes copied" etc. I understand that its requires some work and ready to do it If general approach is OK to bitwarden team.
GiteaMirror commented 2026-04-23 17:10:12 -05:00
Author
Owner
Copy Link

@vvolkgang commented on GitHub (Aug 2, 2024):

@qwexter Your second suggestion is in-line with our .NET app and iOS app implementations, that's how we'll want to proceed. If this is something you're interested in working on, here are the requirements for the change:

  1. Toast message is localised and shows the name of the field. Message: {field_name} copied
  2. Stretch goal: Copying a custom field shows the actual field name instead of value copied
<!-- gh-comment-id:2265392774 --> @vvolkgang commented on GitHub (Aug 2, 2024): @qwexter Your second suggestion is in-line with our .NET app and iOS app implementations, that's how we'll want to proceed. If this is something you're interested in working on, here are the requirements for the change: 1. Toast message is localised and shows the name of the field. Message: `{field_name} copied` 2. Stretch goal: Copying a custom field shows the actual field name instead of `value copied`
GiteaMirror commented 2026-04-23 17:10:14 -05:00
Author
Owner
Copy Link

@qwexter commented on GitHub (Aug 5, 2024):

@qwexter Your second suggestion is in-line with our .NET app and iOS app implementations, that's how we'll want to proceed. If this is something you're interested in working on, here are the requirements for the change:

  1. Toast message is localised and shows the name of the field. Message: {field_name} copied
  2. Stretch goal: Copying a custom field shows the actual field name instead of value copied

OK. I'll take it soon

<!-- gh-comment-id:2269208311 --> @qwexter commented on GitHub (Aug 5, 2024): > @qwexter Your second suggestion is in-line with our .NET app and iOS app implementations, that's how we'll want to proceed. If this is something you're interested in working on, here are the requirements for the change: > > 1. Toast message is localised and shows the name of the field. Message: `{field_name} copied` > 2. Stretch goal: Copying a custom field shows the actual field name instead of `value copied` OK. I'll take it soon
GiteaMirror commented 2026-04-23 17:10:15 -05:00
Author
Owner
Copy Link

@luismanson commented on GitHub (Aug 23, 2024):

I noticed this in my phone and worried me. Also found an unaswered post in the forums. https://community.bitwarden.com/t/password-is-copied-in-clear-text/70775
Thanks for working on this!

<!-- gh-comment-id:2305954666 --> @luismanson commented on GitHub (Aug 23, 2024): I noticed this in my phone and worried me. Also found an unaswered post in the forums. https://community.bitwarden.com/t/password-is-copied-in-clear-text/70775 Thanks for working on this!
GiteaMirror commented 2026-04-23 17:10:16 -05:00
Author
Owner
Copy Link

@qwexter commented on GitHub (Sep 6, 2024):

@vvolkgang I found one moment that I think we should highlight.
I've started work on this issue and found that on Android 13 and more modern we have this way to notify users that something was copied:
Android 13 and more modern
And I can't change this behaviour or show extra text in common way (in way when all notifications works well)
And in this case the behaviour that we discuss before will be work only on devices with android less 13. Is it ok?

<!-- gh-comment-id:2333496618 --> @qwexter commented on GitHub (Sep 6, 2024): @vvolkgang I found one moment that I think we should highlight. I've started work on this issue and found that on Android 13 and more modern we have this way to notify users that something was copied: ![Android 13 and more modern](https://developer.android.com/static/images/about/versions/13/new-copy-paste-UI.gif) And I can't change this behaviour or show extra text in common way (in way when all notifications works well) And in this case the behaviour that we discuss before will be work only on devices with android less 13. Is it ok?
GiteaMirror commented 2026-04-23 17:10:17 -05:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 4, 2024):

I Jus wondering, Is this issue still open?
Screenshot_20241204_225916_Bitwarden Beta
Screenshot_20241204_225922_Bitwarden Beta
" New its says copie to clipboard " insted of "username copied/password cpiede, or show the Username/password
Version: 2024.11.7 (19528)

<!-- gh-comment-id:2518739260 --> @ghost commented on GitHub (Dec 4, 2024): I Jus wondering, Is this issue still open? ![Screenshot_20241204_225916_Bitwarden Beta](https://github.com/user-attachments/assets/a6706781-9409-41b5-aa89-7987a5e74e11) ![Screenshot_20241204_225922_Bitwarden Beta](https://github.com/user-attachments/assets/74783eb0-225b-4345-aa77-a309df1a3c92) " New its says copie to clipboard " insted of "username copied/password cpiede, or show `the Username/password` Version: 2024.11.7 (19528)
GiteaMirror commented 2026-04-23 17:10:20 -05:00
Author
Owner
Copy Link

@luismanson commented on GitHub (Dec 4, 2024):

seems to be solved :)

<!-- gh-comment-id:2518773739 --> @luismanson commented on GitHub (Dec 4, 2024): seems to be solved :)
GiteaMirror commented 2026-04-23 17:10:21 -05:00
Author
Owner
Copy Link

@likevi9528 commented on GitHub (Dec 5, 2024):

Version: 2024.12.0 (19548)
This issue still exists..

1733374383558

<!-- gh-comment-id:2519110003 --> @likevi9528 commented on GitHub (Dec 5, 2024): Version: 2024.12.0 (19548) This issue still exists.. ![1733374383558](https://github.com/user-attachments/assets/1b7470f2-2d33-4688-900a-d6444357aba2)
GiteaMirror commented 2026-04-23 17:10:22 -05:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 5, 2024):

Version: 2024.12.0 (19548) This issue still exists..

Screenshot_20241204_225916_Bitwarden Beta
Android 14
SAM-A15
I test both the new realese : Version: 2024.11.7 (19528), and the bete Version : 2024.12.0 (19533) Seem to be fixes for me!

<!-- gh-comment-id:2519744545 --> @ghost commented on GitHub (Dec 5, 2024): > Version: 2024.12.0 (19548) This issue still exists.. > > ![Screenshot_20241204_225916_Bitwarden Beta](https://github.com/user-attachments/assets/458aa925-a38e-44f0-984c-5aebde61828f) Android 14 SAM-A15 I test both the new realese : Version: 2024.11.7 (19528), and the `bete` Version : 2024.12.0 (19533) Seem to be fixes for me!
GiteaMirror commented 2026-04-23 17:10:24 -05:00
Author
Owner
Copy Link

@likevi9528 commented on GitHub (Dec 5, 2024):

Android 12
Version: 2024.12.0 (19548) beta

I downloaded the latest beta version from actions, and also tested the latest beta downloaded from release, and the situation remained the same.
Actions
Download_url

@maxmini1

I test both the new realese : Version: 2024.11.7 (19528), and the bete Version : 2024.12.0 (19533) Seem to be fixes for me!

<!-- gh-comment-id:2520240040 --> @likevi9528 commented on GitHub (Dec 5, 2024): Android 12 Version: 2024.12.0 (19548) beta I downloaded the latest beta version from actions, and also tested the latest beta downloaded from release, and the situation remained the same. [Actions](https://github.com/bitwarden/android/actions/runs/12148230021) [Download_url](https://github.com/bitwarden/android/actions/runs/12148230021/artifacts/2270111979) @maxmini1 > I test both the new realese : Version: 2024.11.7 (19528), and the `bete` Version : 2024.12.0 (19533) Seem to be fixes for me!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#38894
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?