github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-16 15:13:15 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2837] [PM-3273][PM-4679] New owner/admin permission on login #3838

New Issue
Closed
opened 2025-11-26 23:37:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:37:46 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2837

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When a user has it's privileges elevated to owner/admin, the user has to set a password.

Code changes

Set ForcePasswordResetReason on login, check and launch a modal to set a password if needed on landing page. The user will be always prompted for a password set until the user has set it.
Since we can't get the decryption option until the next login, we have to set the HasMasterPassword property manually in state for the current session.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/3bd4b352-0879-4373-8da1-533d057a99e6

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2837 **State:** closed **Merged:** Yes --- ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> When a user has it's privileges elevated to owner/admin, the user has to set a password. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Set `ForcePasswordResetReason` on login, check and launch a modal to set a password if needed on landing page. The user will be always prompted for a password set until the user has set it. Since we can't get the decryption option until the next login, we have to set the `HasMasterPassword` property manually in state for the current session. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/3bd4b352-0879-4373-8da1-533d057a99e6 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:37:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?