github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2714] [PM-3510] Implement Account Security Settings view #3763

New Issue
Closed
opened 2025-11-26 23:36:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:59 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2714

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement account security settings view.

Code changes

  • BaseViewModel: Provide with a quick method to check connection.
  • PickerViewModel: Improved initialization and now someone can Select an item without prompting and also checks that the selected value is different than the previous one to perform actions.
  • SecuritySettingsPage/ViewModel: Implemented new view
  • UserPinService: New service created to handle user Pin related logic so we don't clutter the VMs
  • LoginPasswordlessRequestListPage/ViewModel: Added empty placeholder and logic to show/hide it based on the list items.
  • A11yExtensions: Added extension method to verbalize a TimeSpan useful for screen readers, like on custom session timeout.

Screenshots

Account Security iOS Light

Account Security iOS Light

Account Security iOS Light 2

Account Security iOS Light 2

Account Security iOS Dark

Account Security iOS Light

Account security iOS Dark 2

Account security iOS Dark 2

Account Security Android Light

Account Security Android Light

Account Security Android LIght 2

Account Security Android LIght 2

Account Security Android Dark

Account Security Android Dark

Account Security Android Dark 2

Account Security Android Dark 2

Empty pending login requests iOS

Empty pending login requests iOS

Empty pending login requests iOS Dark

Empty pending login requests iOS Dark

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2714 **State:** closed **Merged:** Yes --- ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implement account security settings view. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **BaseViewModel:** Provide with a quick method to check connection. * **PickerViewModel:** Improved initialization and now someone can `Select` an item without prompting and also checks that the selected value is different than the previous one to perform actions. * **SecuritySettingsPage/ViewModel:** Implemented new view * **UserPinService:** New service created to handle user Pin related logic so we don't clutter the VMs * **LoginPasswordlessRequestListPage/ViewModel:** Added empty placeholder and logic to show/hide it based on the list items. * **A11yExtensions:** Added extension method to verbalize a `TimeSpan` useful for screen readers, like on custom session timeout. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Account Security iOS Light <img width="314" alt="Account Security iOS Light" src="https://github.com/bitwarden/mobile/assets/15682323/17cf64e5-845f-4eff-b75f-17333f191517"> ### Account Security iOS Light 2 <img width="314" alt="Account Security iOS Light 2" src="https://github.com/bitwarden/mobile/assets/15682323/446b579c-c872-4dcd-a610-ebbe112fcfd9"> ### Account Security iOS Dark <img width="314" alt="Account Security iOS Light" src="https://github.com/bitwarden/mobile/assets/15682323/8f18e4b5-d059-4e84-b10d-cdcb586bcb7b"> ### Account security iOS Dark 2 <img width="314" alt="Account security iOS Dark 2" src="https://github.com/bitwarden/mobile/assets/15682323/d83b39dd-3115-49a3-9108-848e97b1c7d7"> ### Account Security Android Light <img width="314" alt="Account Security Android Light" src="https://github.com/bitwarden/mobile/assets/15682323/2766bd85-049b-4dfb-92fe-5def9138839c"> ### Account Security Android LIght 2 <img width="314" alt="Account Security Android LIght 2" src="https://github.com/bitwarden/mobile/assets/15682323/bd70356f-3dd1-4860-a910-f64057521601"> ### Account Security Android Dark <img width="314" alt="Account Security Android Dark" src="https://github.com/bitwarden/mobile/assets/15682323/628aad5b-5705-4d71-87ff-77ea706f9b6d"> ### Account Security Android Dark 2 <img width="314" alt="Account Security Android Dark 2" src="https://github.com/bitwarden/mobile/assets/15682323/6a045908-8dee-44af-96a9-55ac886bfd13"> ### Empty pending login requests iOS <img width="314" alt="Empty pending login requests iOS" src="https://github.com/bitwarden/mobile/assets/15682323/8828ec6c-ef3f-4a79-a93b-409c56dc6d2e"> ### Empty pending login requests iOS Dark <img width="314" alt="Empty pending login requests iOS Dark" src="https://github.com/bitwarden/mobile/assets/15682323/fa1a156e-1a52-4b28-b5d2-4ce3fb8230d7"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3763
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?