github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2684] [PM-3424] Make mobile app navigation significantly more responsive during use #3735

New Issue
Closed
opened 2025-11-26 23:36:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:40 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2684

State: closed
Merged: No

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

On each content page navigation in the mobile app, a significant delay (400ms) occurs in which a loading spinner is shown, even if nothing is loading, making the app feel quite laggy during use. This delay is introduced by a Task.Delay of 400ms on the codepath that displays the content. I'm not quite sure why the delay is so long, by the variable name it is some kind of animation delay, but the transition animation has long finished by the time the delay is done.

Either way, removing the delay seems to cause no issues and makes the app feel much more responsive (see the videos below).

Code changes

  • file.ext: Description of what was changed and why

Screenshots

https://github.com/bitwarden/mobile/assets/11866552/51159fec-a79e-4a2c-b590-97db4adbba97

https://github.com/bitwarden/mobile/assets/11866552/b9320d13-31f8-41a1-882a-50b45f6b7a18

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2684 **State:** closed **Merged:** No --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective On each content page navigation in the mobile app, a significant delay (400ms) occurs in which a loading spinner is shown, even if nothing is loading, making the app feel quite laggy during use. This delay is introduced by a `Task.Delay` of 400ms on the codepath that displays the content. I'm not quite sure why the delay is so long, by the variable name it is some kind of animation delay, but the transition animation has long finished by the time the delay is done. Either way, removing the delay seems to cause no issues and makes the app feel much more responsive (see the videos below). ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots https://github.com/bitwarden/mobile/assets/11866552/51159fec-a79e-4a2c-b590-97db4adbba97 https://github.com/bitwarden/mobile/assets/11866552/b9320d13-31f8-41a1-882a-50b45f6b7a18 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?