github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 22:08:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6528] [MERGED] PM-31664: Add new SnackbarRelay type specific for the View Screen #37146

New Issue
Closed
opened 2026-04-21 04:13:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 04:13:47 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6528
Author: @david-livefront
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @david-livefront

Base: main ← Head: PM-31664-archiving-snackbar-bug

📝 Commits (1)

  • 506c778 PM-31664: Add new SnackbarRelay type specific for the View Screen

📊 Changes

6 files changed (+21 additions, -4 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/model/SnackbarRelay.kt (+12 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+2 -2)

📄 Description

🎟️ Tracking

PM-31664

📔 Objective

This PR adds two new SnackbarRelay values for the archiving and unarchiving an item from the VaultItemScreen. This is required because when the normal relay event is sent, the VaultItemViewModel was consuming it right away and the subsequent screens we not getting the event. Providing it its own relay type resolves this issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6528 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-31664-archiving-snackbar-bug` --- ### 📝 Commits (1) - [`506c778`](https://github.com/bitwarden/android/commit/506c778cbb5231d90301a2460b9884b15e4635e8) PM-31664: Add new SnackbarRelay type specific for the View Screen ### 📊 Changes **6 files changed** (+21 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/model/SnackbarRelay.kt` (+12 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+2 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-31664](https://bitwarden.atlassian.net/browse/PM-31664) ## 📔 Objective This PR adds two new SnackbarRelay values for the archiving and unarchiving an item from the `VaultItemScreen`. This is required because when the normal relay event is sent, the `VaultItemViewModel` was consuming it right away and the subsequent screens we not getting the event. Providing it its own relay type resolves this issue. [PM-31664]: https://bitwarden.atlassian.net/browse/PM-31664?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 04:13:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#37146