github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6282] [MERGED] [PM-29913] ci: Fix release notes fetch failure while creating GitHub Releases #36956

New Issue
Closed
opened 2026-04-21 04:02:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 04:02:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6282
Author: @vvolkgang
Created: 12/17/2025
Status: ✅ Merged
Merged: 12/19/2025
Merged by: @mpbw2

Base: main ← Head: vvolkgang/fix-release-notes-jira

📝 Commits (7)

  • 3514dcf Update release ticket field id
  • 58f12d0 Improve error handling when fields aren't found
  • 86fc0d7 Add info to the log message when jira api calls fail
  • abe2ace Log custom fields when field or content aren't found.
  • f837f35 Update workflow logging when script fails for other reasons other than the fetch
  • c7b6f5c Fix script exit code handling and improve logs
  • d4ea15b Update examples in script readme

📊 Changes

3 files changed (+43 additions, -14 deletions)

View changed files

📝 .github/scripts/jira-get-release-notes/README.md (+2 -2)
📝 .github/scripts/jira-get-release-notes/jira_release_notes.py (+31 -6)
📝 .github/workflows/github-release.yml (+10 -6)

📄 Description

🎟️ Tracking

PM-29913

📔 Objective

While creating a GitHub Release, our workflow started to fail to retrieve release notes. This happened because the ticket field name changed after the ticket type structure was recently updated.

As part of this PR we're fixing the issue by updating the field name and improving logging in case something similar happens again. Script was non intentionally executed with python3 instead of python, changed it based on internal suggestion without any specific reason other.

Test runs:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6282 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 12/19/2025 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `main` ← **Head:** `vvolkgang/fix-release-notes-jira` --- ### 📝 Commits (7) - [`3514dcf`](https://github.com/bitwarden/android/commit/3514dcf5dbaff7f4a284efe202e9a7450168824a) Update release ticket field id - [`58f12d0`](https://github.com/bitwarden/android/commit/58f12d09f0c9b7b3332bb6747948cc65f4bf5932) Improve error handling when fields aren't found - [`86fc0d7`](https://github.com/bitwarden/android/commit/86fc0d7fd113ef4e7821c623fe00d4be3ec80d20) Add info to the log message when jira api calls fail - [`abe2ace`](https://github.com/bitwarden/android/commit/abe2ace617278ccba8cc62bec32a5fd395467bc1) Log custom fields when field or content aren't found. - [`f837f35`](https://github.com/bitwarden/android/commit/f837f35ee3e8fbd16f9800eedae74952a90df424) Update workflow logging when script fails for other reasons other than the fetch - [`c7b6f5c`](https://github.com/bitwarden/android/commit/c7b6f5cb64ce79fc62fc2215f26e15a49c7ecbc8) Fix script exit code handling and improve logs - [`d4ea15b`](https://github.com/bitwarden/android/commit/d4ea15bc5e85152b9f72fac64f07cea9aa4cfa3d) Update examples in script readme ### 📊 Changes **3 files changed** (+43 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.github/scripts/jira-get-release-notes/README.md` (+2 -2) 📝 `.github/scripts/jira-get-release-notes/jira_release_notes.py` (+31 -6) 📝 `.github/workflows/github-release.yml` (+10 -6) </details> ### 📄 Description ## 🎟️ Tracking PM-29913 ## 📔 Objective While creating a GitHub Release, our workflow started to fail to retrieve release notes. This happened because the ticket field name changed after the ticket type structure was recently updated. As part of this PR we're fixing the issue by updating the field name and improving logging in case something similar happens again. Script was non intentionally executed with `python3` instead of `python`, changed it based on internal suggestion without any specific reason other. Test runs: * Happy path - https://github.com/bitwarden/android/actions/runs/20318635935 * Release notes fetching fails, helpful logs are available and workflow still succeeds - https://github.com/bitwarden/android/actions/runs/20344744516 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 04:02:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#36956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?