github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2623] [PM-2297] Login with trusted device (Flow 2) #3688

New Issue
Closed
opened 2025-11-26 23:36:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:08 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2623

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

After an SSO Login with an organisation that has TDE enabled:

  • if the device is trusted, navigate to the users vault and decrypt the user's key with the device key.
  • if the device is not trusted, navigate to the device approval options screen.

Code changes

Additionally to the changes required to do the logic for the objective of the PR, navigations for the device approval options were also added to the iOS extensions.
Models were also updated with additional properties to match server responses.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/71ed138d-0736-4286-82c8-d955d04c3252

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2623 **State:** closed **Merged:** Yes --- ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> After an SSO Login with an organisation that has TDE enabled: - if the device is trusted, navigate to the users vault and decrypt the user's key with the device key. - if the device is not trusted, navigate to the device approval options screen. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Additionally to the changes required to do the logic for the objective of the PR, navigations for the device approval options were also added to the iOS extensions. Models were also updated with additional properties to match server responses. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/71ed138d-0736-4286-82c8-d955d04c3252 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3688
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?