github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2621] [PM-3041] Add the possibility to require master password with biometrics on app reset #3687

New Issue
Closed
opened 2025-11-26 23:36:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:08 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2621

State: closed
Merged: No

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR addresses issue #2032, which is the possibility of setting if the app should ask for a master password with biometrics authentication on restart.

Code changes

  • LockPageViewModel.cs: The addition of a condition to determine if the master password should be used instead
  • SettingsPageViewModel.cs: Some refactoring to enable code reuse, and the code allowing to show the popup just after biometrics set up to ask if the master password should be required after the app reset
  • AppResources.Designer.cs: Removal of Pin prefix from the translation key
  • AppResources.resx: Removal of Pin prefix from the translation key
  • IStateService.cs: The getter and setter methods declaration for the new option
  • Constants.cs: The new option key's constant
  • src/Core/Services/StateService.cs: The getter and setter methods implementation for the new option

Screenshots

Screenshot_1689472687

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2621 **State:** closed **Merged:** No --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective This PR addresses issue #2032, which is the possibility of setting if the app should ask for a master password with biometrics authentication on restart. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LockPageViewModel.cs:** The addition of a condition to determine if the master password should be used instead * **SettingsPageViewModel.cs:** Some refactoring to enable code reuse, and the code allowing to show the popup just after biometrics set up to ask if the master password should be required after the app reset * **AppResources.Designer.cs:** Removal of `Pin` prefix from the translation key * **AppResources.resx:** Removal of `Pin` prefix from the translation key * **IStateService.cs:** The getter and setter methods declaration for the new option * **Constants.cs:** The new option key's constant * **src/Core/Services/StateService.cs:** The getter and setter methods implementation for the new option ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![Screenshot_1689472687](https://github.com/bitwarden/mobile/assets/13522017/8a4742d7-c0f1-4ad6-bdc8-db863e0ff9f5) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?